Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UWP] Fix CommandBar Overlaying NavigationPage Content #593

Merged
merged 1 commit into from Dec 3, 2016

Conversation

@jimmgarrido
Copy link
Collaborator

commented Dec 2, 2016

Description of Change

On mobile, the CommandBar was covering the content inside a NavigationPage because the container area was not being updated after the CommandBar was moved to the bottom of the screen.

The TabbedPage didn't have this issue as it used a TabbedPagePresenter to respond to the size change so I copied that code to a more generally named FormsPresenter class and used it also for the PageControl used by the NavigationPage renderer.

Bugs Fixed

API Changes

None

Behavioral Changes

None

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard
  • Consolidate commits as makes sense
@hartez
hartez approved these changes Dec 2, 2016
@rmarinho

This comment has been minimized.

Copy link
Member

commented Dec 2, 2016

needs rebase @jimmgarrido

@jimmgarrido jimmgarrido force-pushed the jimmgarrido:uwp_toolbar_overlay branch from a8c3efe to cd8f438 Dec 2, 2016

@jimmgarrido

This comment has been minimized.

Copy link
Collaborator Author

commented Dec 2, 2016

@rmarinho rebased

@rmarinho rmarinho merged commit 3da9a4c into xamarin:master Dec 3, 2016

1 of 3 checks passed

OSX-Debug-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle 8 :: OSX Debug : Snapshot dependency failed to start: ... Windows Debug
Details
iOS10-UITests-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle 8 :: UI Tests :: OSX Test Cloud Package - Run iOS Unified iOS10 : Snapshot depende…
Details
Windows-Debug-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle 8 :: Windows Debug : Tests passed: 3615, ignored: 10
Details
rmarinho added a commit that referenced this pull request Dec 3, 2016

@jimmgarrido jimmgarrido deleted the jimmgarrido:uwp_toolbar_overlay branch Dec 13, 2016

@samhouts samhouts modified the milestones: 2.3.4, 2.3.3 Jun 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.