Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shell hamburger #5961

Merged
merged 4 commits into from Apr 25, 2019

Conversation

@PureWeen
Copy link
Contributor

commented Apr 19, 2019

Description of Change

Remove the bundled 3bar.png files. From what I can tell these won't get auto included when bundled with a nuget. In theory you can bundle content with the nuspec but iOS won't pickup those resources and pull them into the build. We could add a target to add the resource in but seeing as how it's just 3 horizontal lines, just drawing it seemed like the best solution for now. The PNG is basically just 3 rectangles.

Issues Resolved

Platforms Affected

  • iOS

Before/After Screenshots

One is the png and the other is the drawing

image

Testing Procedure

Run the shell and make sure the hamburger shows up and looks ok

PR Checklist

  • Has automated tests
  • Rebased on top of the target branch at time of PR
  • Changes adhere to coding standard

@PureWeen PureWeen requested a review from rmarinho Apr 19, 2019

PureWeen added some commits Apr 19, 2019

@jcmanke

This comment has been minimized.

Copy link
Contributor

commented Apr 22, 2019

I'm certain that I've made a NuGet package that included images for iOS as BundleResources before and it worked, but I like the workaround.

@samhouts samhouts added this to In Review in vCurrent (4.0.0) Apr 22, 2019

@samhouts samhouts added this to Ready for Review (PRs) in Sprint 152 Apr 22, 2019

@samhouts samhouts self-requested a review Apr 22, 2019

@PureWeen

This comment has been minimized.

Copy link
Contributor Author

commented Apr 23, 2019

@jcmanke I messed around with it a bit and was able to create a package that included them with the nuget but it still didn't include them at compile time. This PR (NuGet/NuGet.Client#225) added those types of resources to the white list but I think not until xamarin projects get converted to full on sdk projects will that type of bundling just work out of the box

UWP does work when you include assets like this but ios/android doesn't at this point (AFAICT)

@samhouts samhouts requested review from hartez and removed request for rmarinho Apr 24, 2019

@samhouts samhouts requested review from kingces95 and removed request for hartez Apr 24, 2019

@kingces95
Copy link
Member

left a comment

Bring back the Turtle!


for(int i = 0; i< 3; i++)
{
ctx.MoveTo(1f, start + i * (size * 2));

This comment has been minimized.

Copy link
@kingces95

kingces95 Apr 25, 2019

Member

Nice. Just like LOGO writer.

@PureWeen PureWeen merged commit fb7f7a2 into 4.0.0 Apr 25, 2019

13 of 16 checks passed

Xamarin Forms Beta Build #PR-5961 - (2605633) failed
Details
Xamarin Forms Beta (Build Windows Phase Release) Build Windows Phase Release failed
Details
Xamarin Forms Beta (Build Windows Phase debug) Build Windows Phase debug failed
Details
Xamarin Forms Build #PR-5961 - (2618669) succeeded
Details
Xamarin Forms (Build Windows Phase Debug,any cpu) Build Windows Phase Debug,any cpu succeeded
Details
Xamarin Forms (Nuget Phase) Nuget Phase succeeded
Details
Xamarin Forms (OSX Phase) OSX Phase succeeded
Details
Xamarin Forms (Prepare Build Phase) Prepare Build Phase succeeded
Details
Xamarin Forms (Test Phase debug) Test Phase debug succeeded
Details
Xamarin Forms Beta (Build Android [Fast Renderers]) Build Android [Fast Renderers] succeeded
Details
Xamarin Forms Beta (Build Android [Legacy Renderers]) Build Android [Legacy Renderers] succeeded
Details
Xamarin Forms Beta (Build Android [Pre-AppCompat]) Build Android [Pre-AppCompat] succeeded
Details
Xamarin Forms Beta (OSX Phase) OSX Phase succeeded
Details
Xamarin Forms Beta (Prepare Build Phase) Prepare Build Phase succeeded
Details
license/cla All CLA requirements met.
Details
xamarin-forms-ci #PR-5961 - (1139) succeeded
Details

vCurrent (4.0.0) automation moved this from In Review to Done Apr 25, 2019

Sprint 152 automation moved this from Ready for Review (PRs) to Done Apr 25, 2019

@PureWeen PureWeen deleted the shell_hamburger branch Apr 25, 2019

@samhouts samhouts added this to the 4.0.0 milestone Apr 29, 2019

AxelUser added a commit to AxelUser/Xamarin.Forms that referenced this pull request Jun 15, 2019

Shell hamburger (xamarin#5961)
* Draw the hamburger if the user hasn't supplied an icon

* move variable

* remove excess code

* remove public
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.