New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug-39359 #599

Merged
merged 1 commit into from Jan 12, 2017

Conversation

Projects
None yet
6 participants
@fengrui358
Contributor

fengrui358 commented Dec 4, 2016

Description of Change

Fix bug-39359 UriImageSource does cache failed HTTP responses

Bugs Fixed

https://bugzilla.xamarin.com/show_bug.cgi?id=39359

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard
  • Consolidate commits as makes sense
fix bug-39359
UriImageSource does cache failed HTTP responses
@dnfclas

This comment has been minimized.

Show comment
Hide comment
@dnfclas

dnfclas Dec 4, 2016

Hi @fengrui358, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
We will now validate the agreement and then real humans will evaluate your PR.

TTYL, DNFBOT;

dnfclas commented Dec 4, 2016

Hi @fengrui358, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
We will now validate the agreement and then real humans will evaluate your PR.

TTYL, DNFBOT;

@dnfclas dnfclas added the cla-signed label Dec 4, 2016

@StephaneDelcroix StephaneDelcroix referenced this pull request Dec 4, 2016

Closed

Fix Bug 39359 #597

@StephaneDelcroix

Your PR summary indicates that this PR contains tests, and I don't see any

@fengrui358

This comment has been minimized.

Show comment
Hide comment
@fengrui358

fengrui358 Dec 4, 2016

Contributor

Sorry, this PR have no tests because I fix this bug like the platform of winRT.
(I copy the code from the file of "Xamarin.Forms.Platform.WinRT\WindowsBasePlatformServices.cs line 103")

Contributor

fengrui358 commented Dec 4, 2016

Sorry, this PR have no tests because I fix this bug like the platform of winRT.
(I copy the code from the file of "Xamarin.Forms.Platform.WinRT\WindowsBasePlatformServices.cs line 103")

@samhouts

This comment has been minimized.

Show comment
Hide comment
@samhouts

samhouts Dec 5, 2016

Member

Related to @rmarinho's #28.

Member

samhouts commented Dec 5, 2016

Related to @rmarinho's #28.

@fengrui358

This comment has been minimized.

Show comment
Hide comment
@fengrui358

fengrui358 Dec 7, 2016

Contributor

@StephaneDelcroix Can you review again?

Contributor

fengrui358 commented Dec 7, 2016

@StephaneDelcroix Can you review again?

@rmarinho rmarinho merged commit e7a7a57 into xamarin:master Jan 12, 2017

5 of 6 checks passed

iOS8-UITests-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle 8 :: UI Tests :: OSX Test Cloud Package - Run iOS Unified IOS8 : Tests failed: 1, …
Details
Android-UITests-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle 8 :: UI Tests :: OSX Test Cloud Package - Run Android 6.0.1 : Tests passed: 349, i…
Details
OSX-Debug-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle 8 :: OSX Debug : Running
Details
Windows-Debug-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle 8 :: Windows Debug : Tests passed: 3615, ignored: 10
Details
iOS10-UITests-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle 8 :: UI Tests :: OSX Test Cloud Package - Run iOS Unified iOS10 : Tests passed: 34…
Details
iOS9-UITests-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle 8 :: UI Tests :: OSX Test Cloud Package - Run iOS Unified iOS9 : Tests passed: 346…
Details

@fengrui358 fengrui358 deleted the fengrui358:fix-bug39359 branch Jan 13, 2017

@samhouts samhouts added this to the 2.3.4 milestone Jun 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment