Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[macOS] Fix transparent ListView background #6050

Merged
merged 2 commits into from May 11, 2019

Conversation

@GalaxiaGuy
Copy link
Contributor

commented Apr 30, 2019

Description of Change

ListView on macOS is implemented using an NSTableView inside an NSScrollView. This sets the NSScrollView to not draw its background allowing a color with an a non-1 alpha to be set as the background color to a ListView.

Issues Resolved

#6021 also mentions an issue about cell background color which is not part of this. Fixing that may be considered a breaking change as discussed in #4002.

API Changes

None

Platforms Affected

  • macOS

Behavioral/Visual Changes

A background color with alpha less than 1 set on a ListView now renders correctly.

Before/After Screenshots

Before

After

Testing Procedure

I added a manual test case, Github6021, to the control gallery.

PR Checklist

  • Has automated tests
  • Rebased on top of the target branch at time of PR
  • Changes adhere to coding standard
@dnfclas

This comment has been minimized.

Copy link

commented Apr 30, 2019

CLA assistant check
All CLA requirements met.

@samhouts samhouts merged commit 6c6d43d into xamarin:master May 11, 2019

7 checks passed

Xamarin Forms Build #PR-6050 - (2668204) succeeded
Details
Xamarin Forms (Build Windows Phase Debug,any cpu) Build Windows Phase Debug,any cpu succeeded
Details
Xamarin Forms (Nuget Phase) Nuget Phase succeeded
Details
Xamarin Forms (OSX Phase) OSX Phase succeeded
Details
Xamarin Forms (Prepare Build Phase) Prepare Build Phase succeeded
Details
Xamarin Forms (Test Phase Debug) Test Phase Debug succeeded
Details
license/cla All CLA requirements met.
Details

v4.1.0 automation moved this from In Review to Done May 11, 2019

@samhouts samhouts added this to Done in vCurrent (4.2.0) May 29, 2019

@samhouts samhouts removed this from Done in v4.1.0 May 29, 2019

@samhouts samhouts added this to the 4.1.0 milestone Jun 4, 2019

@samhouts samhouts removed this from Done in vCurrent (4.2.0) Jun 4, 2019

@samhouts samhouts added this to Done in v4.1.0 Jun 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
4 participants
You can’t perform that action at this time.