New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Build] Update builds, remove submodule, update AssemblyInfo with GitInfo #6068
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggested a bunch of changes via individual comments. The approach can be simplified significantly by relying on the SDK-style project automatic assembly info generation, which the copied targets are intended to support/extend. See https://github.com/dotnet/sdk/blob/master/src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.GenerateAssemblyInfo.targets
// You can specify all the values or you can default the Build and Revision Numbers | ||
// by using the '*' as shown below: | ||
// [assembly: AssemblyVersion("1.0.*")] | ||
[assembly: Guid ("d3f9fea6-cce8-4c30-b0d2-197b40c50757")] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
check with the Tizen guys, but I don't think this will be used as ComVisible is set to false
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yap, you are right. Can remove.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks fine to me. I discussed this with @StephaneDelcroix, and this works for him, too. If it turns out to be brittle, we can adjust it later as needed.
Added unit test for the .Core .Xaml .Maps .Build.Tasks. Need to enable this check also , got some issues with IVT. Looking at the info we know see :
Platform side
|
Description of Change
Using msbuild and GitInfo to set the AssemblyVersion and the package name.
All projects will have the right information related to the commit and build from azdo.
The sdk projects support out of the box the GenerateAssemblyInfo, for the other "old" projects we use the Nuget MSBuild.GenerateAssemblyInfo
Issues Resolved
API Changes
None
Platforms Affected
Behavioral/Visual Changes
None
Before/After Screenshots
Not applicable
Testing Procedure
PR Checklist