New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] Fix crash when pushing page on stack on orientation change #607

Merged
merged 2 commits into from Dec 6, 2016

Conversation

Projects
None yet
4 participants
@adrianknight89
Contributor

adrianknight89 commented Dec 5, 2016

Description of Change

if you push a page on the navigation stack on device orientation change, this will crash because we are trying to update the element children collection while foreach is in progress during a layout cycle. There is a repro attached to the bug description.

Bugs Fixed

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard
  • Consolidate commits as makes sense
@rmarinho

This comment has been minimized.

Show comment
Hide comment
@rmarinho

rmarinho Dec 5, 2016

Member

Can you rebase please.. need a fix from master..

Member

rmarinho commented Dec 5, 2016

Can you rebase please.. need a fix from master..

@adrianknight89

This comment has been minimized.

Show comment
Hide comment
@adrianknight89
Contributor

adrianknight89 commented Dec 5, 2016

@rmarinho Done.

@rmarinho rmarinho merged commit 5a2cb89 into xamarin:master Dec 6, 2016

2 of 3 checks passed

Android-UITests-C8 Started TeamCity Build Xamarin.Forms :: Debug :: Cycle 8 :: UI Tests :: OSX Test Cloud Package - Run Android 6.0.1
Details
OSX-Debug-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle 8 :: OSX Debug : Running
Details
Windows-Debug-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle 8 :: Windows Debug : Tests passed: 3619, ignored: 10
Details

@samhouts samhouts added this to the 2.3.4 milestone Jun 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment