[iOS] MasterDetailPage master icon should be changeable from any page on the stack #608

Merged
merged 5 commits into from Feb 15, 2017

Conversation

Projects
None yet
4 participants
@adrianknight89
Contributor

adrianknight89 commented Dec 5, 2016

Description of Change

At the moment, Master icon can only be changed if you are on the first page of the detail (NavigationPage). This only addresses the phone side of it since I do not have an iPad. Also, in the bug description, the OP wanted the ability to change icon tinting independently of BarTextColor which controls tinting for both icons and title. This could probably be a future update to go in an effect library.

Bugs Fixed

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard
  • Consolidate commits as makes sense
@@ -644,34 +642,7 @@ void UpdateLeftBarButtonItem(ParentingViewController containerController, Page p
if ((firstPage != pageBeingRemoved && currentChild != firstPage && NavigationPage.GetHasBackButton(currentChild)) || _parentMasterDetailPage == null)

This comment has been minimized.

@adrianknight89

adrianknight89 Dec 5, 2016

Contributor

This expression seems complicated, and it probably makes sense to not complicate it even further. So I refactored below code into its own method and let phone master detail renderer call it freely.

@adrianknight89

adrianknight89 Dec 5, 2016

Contributor

This expression seems complicated, and it probably makes sense to not complicate it even further. So I refactored below code into its own method and let phone master detail renderer call it freely.

@rmarinho

This comment has been minimized.

Show comment
Hide comment
@rmarinho

rmarinho Dec 19, 2016

Member

Needs rebase

Member

rmarinho commented Dec 19, 2016

Needs rebase

@adrianknight89

This comment has been minimized.

Show comment
Hide comment
@adrianknight89

adrianknight89 Dec 19, 2016

Contributor

Done.

Contributor

adrianknight89 commented Dec 19, 2016

Done.

@rmarinho rmarinho merged commit 1d8e098 into xamarin:master Feb 15, 2017

6 checks passed

Android-UITests-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle 8 :: UI Tests :: OSX Test Cloud Package - Run Android 6.0.1 : Tests passed: 352, i…
Details
OSX-Debug-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle 8 :: OSX Debug : Running
Details
Windows-Debug-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle 8 :: Windows Debug : Tests passed: 3738, ignored: 10
Details
iOS10-UITests-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle 8 :: UI Tests :: OSX Test Cloud Package - Run iOS Unified iOS10 : Tests passed: 34…
Details
iOS8-UITests-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle 8 :: UI Tests :: OSX Test Cloud Package - Run iOS Unified IOS8 : Tests passed: 349…
Details
iOS9-UITests-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle 8 :: UI Tests :: OSX Test Cloud Package - Run iOS Unified iOS9 : Tests passed: 351…
Details

@samhouts samhouts added D-15.4 and removed cla-already-signed labels Oct 10, 2017

@samhouts samhouts added this to the 2.3.5 milestone Jun 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment