Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] Shell _headerView can apparently be null #6164

Merged
merged 1 commit into from May 10, 2019

Conversation

@samhouts
Copy link
Member

commented May 10, 2019

Description of Change

UI Test 5132 was crashing because the FlyoutHeader was null on loading.

Issues Resolved

n/a

API Changes

None

Platforms Affected

  • iOS

Behavioral/Visual Changes

None

Before/After Screenshots

Not applicable

Testing Procedure

Run G5132. If it doesn't crash, success!

PR Checklist

  • Has automated tests
  • Rebased on top of the target branch at time of PR
  • Changes adhere to coding standard

@samhouts samhouts changed the base branch from master to 4.0.0 May 10, 2019

@samhouts samhouts requested review from PureWeen and rmarinho May 10, 2019

@PureWeen
Copy link
Contributor

left a comment

Ran on iOS and android after setting the header view to null.
Looks good!

@rmarinho rmarinho merged commit 5308051 into 4.0.0 May 10, 2019

16 of 19 checks passed

VSTS: iOS10 Validation UITests Running
Details
VSTS: iOS11 Validation UITests Running
Details
VSTS: iOS12 Validation UITests Running
Details
VSTS: Android API19 Validation Fast Renderers UITests Finished
Details
VSTS: Android API19 Validation Legacy Renderers UITests Finished
Details
VSTS: Android API23 Validation Fast Renderers UITests Finished
Details
VSTS: Android API23 Validation Legacy Renderers UITests Finished
Details
VSTS: Android API25 Validation Fast Renderers UITests Finished
Details
VSTS: Android API25 Validation Legacy Renderers UITests Finished
Details
VSTS: Android API28 Validation Fast Renderers UITests Finished
Details
VSTS: Android API28 Validation Legacy Renderers UITests Finished
Details
Xamarin Forms Build #PR-6164 - (2666664) succeeded
Details
Xamarin Forms (Build Windows Phase Debug,any cpu) Build Windows Phase Debug,any cpu succeeded
Details
Xamarin Forms (Nuget Phase) Nuget Phase succeeded
Details
Xamarin Forms (OSX Phase) OSX Phase succeeded
Details
Xamarin Forms (Prepare Build Phase) Prepare Build Phase succeeded
Details
Xamarin Forms (Test Phase Debug) Test Phase Debug succeeded
Details
license/cla All CLA requirements met.
xamarin-forms-ci #PR-6164 - (1778) succeeded
Details

@PureWeen PureWeen deleted the fix-crash-5132 branch May 10, 2019

@samhouts samhouts added this to Done in vCurrent (4.0.0) May 11, 2019

@samhouts samhouts added this to the 4.0.0 milestone May 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.