Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

item template attached, fix icon propagations #6173

Merged
merged 2 commits into from May 11, 2019

Conversation

Projects
2 participants
@PureWeen
Copy link
Contributor

commented May 11, 2019

Description of Change

  • add propagation for navbarvisible and tabbarvisible to propagate down children
  • changed Shell.ItemTemplate to be an attached property so it can be attached to any Shell
  • fixed implicit Shell creations to properly bind additional properties (like flyouticon)

Issues Resolved

API Changes

Changed:

  • Shell.ItemTemplate to be an attached property

Platforms Affected

  • Core/XAML (all platforms)
  • iOS
  • Android
  • UWP

Testing Procedure

  • I added another flyout item to store shell where you can see these properties set at different hierarchies

PR Checklist

  • Has automated tests
  • Rebased on top of the target branch at time of PR
  • Changes adhere to coding standard

@PureWeen PureWeen requested a review from rmarinho May 11, 2019

@PureWeen PureWeen requested a review from StephaneDelcroix as a code owner May 11, 2019

@PureWeen PureWeen added this to To do in vCurrent (4.0.0) via automation May 11, 2019

@PureWeen PureWeen added this to the 4.0.0 milestone May 11, 2019

@PureWeen PureWeen removed the request for review from StephaneDelcroix May 11, 2019

@samhouts samhouts merged commit 056ec1a into 4.0.0 May 11, 2019

16 of 19 checks passed

VSTS: Android API19 Validation Legacy Renderers UITests Finished
Details
VSTS: Android API28 Validation Legacy Renderers UITests Finished
Details
VSTS: iOS10 Validation UITests Finished
Details
VSTS: Android API19 Validation Fast Renderers UITests Finished
Details
VSTS: Android API23 Validation Fast Renderers UITests Finished
Details
VSTS: Android API23 Validation Legacy Renderers UITests Finished
Details
VSTS: Android API25 Validation Fast Renderers UITests Finished
Details
VSTS: Android API25 Validation Legacy Renderers UITests Finished
Details
VSTS: Android API28 Validation Fast Renderers UITests Finished
Details
VSTS: iOS11 Validation UITests Finished
Details
VSTS: iOS12 Validation UITests Finished
Details
Xamarin Forms Build #PR-6173 - (2668542) succeeded
Details
Xamarin Forms (Build Windows Phase Debug,any cpu) Build Windows Phase Debug,any cpu succeeded
Details
Xamarin Forms (Nuget Phase) Nuget Phase succeeded
Details
Xamarin Forms (OSX Phase) OSX Phase succeeded
Details
Xamarin Forms (Prepare Build Phase) Prepare Build Phase succeeded
Details
Xamarin Forms (Test Phase Debug) Test Phase Debug succeeded
Details
license/cla All CLA requirements met.
Details
xamarin-forms-ci #PR-6173 - (1792) succeeded
Details

vCurrent (4.0.0) automation moved this from To do to Done May 11, 2019

@samhouts samhouts deleted the shell_flyouticon_bindings branch May 11, 2019

@samhouts samhouts added this to Done in Sprint 152 May 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.