New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xamlc compiled trigger #629

Merged
merged 3 commits into from Dec 14, 2016

Conversation

Projects
None yet
3 participants
@StephaneDelcroix
Member

StephaneDelcroix commented Dec 9, 2016

Description of Change

Based on #622

Compiled version of Trigger iValueProvider

this was already covered by existing tests

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard
  • Consolidate commits as makes sense
@@ -14,7 +14,7 @@ public sealed class PropertyCondition : Condition, IValueProvider
public PropertyCondition()
{
_stateProperty = BindableProperty.CreateAttached("State", typeof(bool), typeof(DataTrigger), false, propertyChanged: OnStatePropertyChanged);
_stateProperty = BindableProperty.CreateAttached("State", typeof(bool), typeof(PropertyCondition), false, propertyChanged: OnStatePropertyChanged);

This comment has been minimized.

@samhouts

samhouts Dec 12, 2016

Member

That seems significant.

@samhouts

samhouts Dec 12, 2016

Member

That seems significant.

This comment has been minimized.

@StephaneDelcroix

StephaneDelcroix Dec 12, 2016

Member

actually, it is not. AT ALL :)

@StephaneDelcroix

StephaneDelcroix Dec 12, 2016

Member

actually, it is not. AT ALL :)

This comment has been minimized.

@samhouts

samhouts Dec 12, 2016

Member

👍

@samhouts
Show outdated Hide outdated Xamarin.Forms.Build.Tasks/CompiledValueProviders/TriggerValueProvider.cs

StephaneDelcroix added some commits Dec 9, 2016

@StephaneDelcroix StephaneDelcroix merged commit 859b058 into master Dec 14, 2016

1 of 3 checks passed

OSX-Debug-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle 8 :: OSX Debug : Snapshot dependency failed to start: ... Windows Debug
Details
iOS9-UITests-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle 8 :: UI Tests :: OSX Test Cloud Package - Run iOS Unified iOS9 : Snapshot dependen…
Details
Windows-Debug-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle 8 :: Windows Debug : Tests passed: 3685, ignored: 10
Details

@StephaneDelcroix StephaneDelcroix deleted the xamlc_compiledTrigger branch Dec 14, 2016

@samhouts samhouts added this to the 2.3.4 milestone Jun 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment