Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] refactoring fixes layouts #6390

Merged
merged 9 commits into from Jul 18, 2019

Conversation

@paymicro
Copy link
Collaborator

commented Jun 3, 2019

Description of Change

Refactoring fixes layouts

Issues Resolved

API Changes

None

Platforms Affected

  • Android

Behavioral/Visual Changes

None

Before/After Screenshots

ListView display glitches
Before
#6355 http://recordit.co/QBMYFWyF0R

After
#6355 http://recordit.co/VBa2CAtHJt
Issue #6439 http://recordit.co/jNVIM4wkGd

Testing Procedure

Fast Renderers and Legacy Renderers

  • UITest 1332
  • UITest 1760
  • UITest 1760_1
  • UITest 5766
  • UITest 5184
  • UITest 6297
  • Issue6282

PR Checklist

  • Has automated tests
  • Rebased on top of the target branch at time of PR
  • Changes adhere to coding standard

@paymicro paymicro added this to the 4.0.0 milestone Jun 3, 2019

@samhouts samhouts added this to In Review in v4.0.0 Jun 3, 2019

@samhouts samhouts added this to Ready for Review (PRs) in Sprint 154 Jun 3, 2019

@paymicro paymicro marked this pull request as ready for review Jun 4, 2019

@paymicro paymicro force-pushed the paymicro/fix-android-layout branch from e6eb223 to 85f2e17 Jun 7, 2019

@PureWeen
Copy link
Contributor

left a comment

Sprint 154 automation moved this from Ready for Review (PRs) to In progress Jun 12, 2019

@samhouts samhouts moved this from In Review to In Progress in v4.0.0 Jun 13, 2019

@paymicro paymicro force-pushed the paymicro/fix-android-layout branch from 85f2e17 to d303012 Jun 13, 2019

@paymicro paymicro requested a review from PureWeen Jun 13, 2019

@PureWeen PureWeen force-pushed the paymicro/fix-android-layout branch from d876e80 to 66e3d0e Jun 18, 2019

@samhouts samhouts requested a review from hartez Jun 19, 2019

@samhouts samhouts modified the milestones: 4.0.0, 3.6.0 Jun 20, 2019

@samhouts samhouts added this to In Progress in v3.6.0 Jun 20, 2019

@samhouts samhouts removed this from In Progress in v4.0.0 Jun 20, 2019

@samhouts samhouts removed this from the 3.6.0 milestone Jun 21, 2019

@samhouts samhouts added this to In Progress in v4.0.0 Jun 21, 2019

@samhouts samhouts added this to In progress in Sprint 155 Jun 25, 2019

@jingliancui

This comment has been minimized.

Copy link

commented Jul 18, 2019

Can you tell me when to release these fixes to nuget?

@adrianknight89

This comment has been minimized.

Copy link
Contributor

commented Jul 18, 2019

Do you publish the nightly Nuget every day now? It'd be great if there was a way for us to know which commits are included in each build.

@jingliancui

This comment has been minimized.

Copy link

commented Jul 18, 2019

@adrianknight89 Sorry, I have no idea for your question.My question is just want to use these fixes for my product asap : )

@PouryaNoufallah96

This comment has been minimized.

Copy link

commented Jul 18, 2019

I still got problem on listview when i scroll some of my lables are cutting . What should i do ? I updates my xamarin forms to last pre release but still have problem

@jingliancui

This comment has been minimized.

Copy link

commented Jul 18, 2019

@PouryaNoufallah96 I think you should monitor this page https://github.com/xamarin/Xamarin.Forms/releases
Code commit is different from release.

@PouryaNoufallah96

This comment has been minimized.

Copy link

commented Jul 18, 2019

@jingliancui

<Frame Style="{StaticResource FrameSectionStyle}"> <Grid> <Grid.ColumnDefinitions> <ColumnDefinition Width="*" /> </Grid.ColumnDefinitions> <StackLayout> <StackLayout Orientation="Horizontal"> <Label Style="{StaticResource TextListHeadline}" Text="{Binding CustomerName}" /> <Label Style="{StaticResource TextTitle}" Text="{Binding CustomerCode}" /> </StackLayout> <StackLayout Orientation="Horizontal"> <Label Margin="20,0,0,0" Style="{StaticResource TextBody}" Text="{Binding Mobile}" /> <Label Style="{StaticResource TextBody}" Text="{Binding Telephone}" /> </StackLayout> <Label Style="{StaticResource TextCaption}" Text="{Binding Address}" /> </StackLayout> </Grid> </Frame>

this is my listview item template . i monitored that page but it doesnt help:(

@PouryaNoufallah96

This comment has been minimized.

Copy link

commented Jul 18, 2019

@jingliancui i realized that when i put CachingStrategy="RecycleElement" this bug shows on scrolling . but now i erase the CachingStrategy property it solved my issue . but whats the solution ? i need CachingStrategy =RecycleElement

@adrianknight89

This comment has been minimized.

Copy link
Contributor

commented Jul 19, 2019

@jingliancui The question was intended for the Forms team :)

@adrianknight89

This comment has been minimized.

Copy link
Contributor

commented Jul 19, 2019

@PouryaNoufallah96 You could try using a nightly build by setting your Nuget package source to https://aka.ms/xf-ci/index.json, but I believe this fix hasn't been built yet since the latest nightly has issues still.

@marunprasadbe13

This comment has been minimized.

Copy link

commented Jul 19, 2019

Could you please confirm whether this fix would be included in any of the upcoming Xamarin.Forms releases ? It is required to resolve all the ListView related issues in Android.

@PouryaNoufallah96

This comment has been minimized.

Copy link

commented Jul 20, 2019

even the search handlers item templates has this issue on scrooling :(

@fpiribauer

This comment has been minimized.

Copy link

commented Jul 22, 2019

@marunprasadbe13 there are already tags for the next service releases. Seems like the relevant commits are included.

@adrianknight89

This comment has been minimized.

Copy link
Contributor

commented Jul 24, 2019

@hartez @PureWeen I just updated to 4.3.0.971-nightly. It fixes my ListView display issues, but ListView scrolling on Android is broken. I have to swipe up and down several times before scrolling can begin (happens 50% of the cases). I'm not sure if the issue is related to this PR.

Edit: Looks like this has to do with the addition of nested scrolling as described here.

@PureWeen

This comment has been minimized.

Copy link
Contributor

commented Jul 24, 2019

@adrianknight89 Yea we'll have that one fixed soon.

My other thought was that perhaps you were hitting this issue on the nightly
#6944 (comment)

We're seeing a few of our UI tests locking up right now from that which we'll have resolved here soon

@PureWeen PureWeen deleted the paymicro/fix-android-layout branch Jul 24, 2019

@samhouts samhouts modified the milestones: 4.0.0, 3.5.0 Aug 1, 2019

@mfeingol

This comment has been minimized.

Copy link

commented Aug 3, 2019

@samhouts: any idea which release versions will see these fixes?

Thanks.

@morphinapg

This comment has been minimized.

Copy link

commented Aug 3, 2019

@mfeingol I installed 4.1.0.618606 and it solved my issues

@mfeingol

This comment has been minimized.

Copy link

commented Aug 3, 2019

@morphinapg: thanks! That version does seem to have fixed my issues on Android.

@jingliancui

This comment has been minimized.

Copy link

commented Aug 6, 2019

#6889
this bug still not fix in 4.1.0.618606

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.