Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] refactoring fixes layouts #6390

Merged
merged 9 commits into from Jul 18, 2019
Merged

[Android] refactoring fixes layouts #6390

merged 9 commits into from Jul 18, 2019

Conversation

@paymicro
Copy link
Contributor

@paymicro paymicro commented Jun 3, 2019

Description of Change

Refactoring fixes layouts

Issues Resolved

API Changes

None

Platforms Affected

  • Android

Behavioral/Visual Changes

None

Before/After Screenshots

ListView display glitches
Before
#6355 http://recordit.co/QBMYFWyF0R

After
#6355 http://recordit.co/VBa2CAtHJt
Issue #6439 http://recordit.co/jNVIM4wkGd

Testing Procedure

Fast Renderers and Legacy Renderers

  • UITest 1332
  • UITest 1760
  • UITest 1760_1
  • UITest 5766
  • UITest 5184
  • UITest 6297
  • Issue6282

PR Checklist

  • Has automated tests
  • Rebased on top of the target branch at time of PR
  • Changes adhere to coding standard
Copy link
Contributor

@PureWeen PureWeen left a comment

Loading

Sprint 154 automation moved this from Ready for Review (PRs) to In progress Jun 12, 2019
@samhouts samhouts moved this from In Review to In Progress in v4.0.0 Jun 13, 2019
@paymicro paymicro force-pushed the paymicro/fix-android-layout branch from 85f2e17 to d303012 Jun 13, 2019
@paymicro paymicro requested a review from PureWeen Jun 13, 2019
@PureWeen PureWeen force-pushed the paymicro/fix-android-layout branch from d876e80 to 66e3d0e Jun 18, 2019
@samhouts samhouts requested a review from hartez Jun 19, 2019
@samhouts samhouts removed this from the 4.0.0 milestone Jun 20, 2019
@samhouts samhouts added this to the 3.6.0 milestone Jun 20, 2019
@samhouts samhouts added this to In Progress in v3.6.0 Jun 20, 2019
@samhouts samhouts removed this from In Progress in v4.0.0 Jun 20, 2019
@samhouts samhouts removed this from the 3.6.0 milestone Jun 21, 2019
@samhouts samhouts added this to In Progress in v4.0.0 Jun 21, 2019
@samhouts samhouts added this to In progress in Sprint 155 Jun 25, 2019
@PouryaNoufallah96
Copy link

@PouryaNoufallah96 PouryaNoufallah96 commented Jul 18, 2019

@jingliancui

<Frame Style="{StaticResource FrameSectionStyle}"> <Grid> <Grid.ColumnDefinitions> <ColumnDefinition Width="*" /> </Grid.ColumnDefinitions> <StackLayout> <StackLayout Orientation="Horizontal"> <Label Style="{StaticResource TextListHeadline}" Text="{Binding CustomerName}" /> <Label Style="{StaticResource TextTitle}" Text="{Binding CustomerCode}" /> </StackLayout> <StackLayout Orientation="Horizontal"> <Label Margin="20,0,0,0" Style="{StaticResource TextBody}" Text="{Binding Mobile}" /> <Label Style="{StaticResource TextBody}" Text="{Binding Telephone}" /> </StackLayout> <Label Style="{StaticResource TextCaption}" Text="{Binding Address}" /> </StackLayout> </Grid> </Frame>

this is my listview item template . i monitored that page but it doesnt help:(

Loading

@PouryaNoufallah96
Copy link

@PouryaNoufallah96 PouryaNoufallah96 commented Jul 18, 2019

@jingliancui i realized that when i put CachingStrategy="RecycleElement" this bug shows on scrolling . but now i erase the CachingStrategy property it solved my issue . but whats the solution ? i need CachingStrategy =RecycleElement

Loading

@adrianknight89
Copy link
Contributor

@adrianknight89 adrianknight89 commented Jul 19, 2019

@jingliancui The question was intended for the Forms team :)

Loading

@adrianknight89
Copy link
Contributor

@adrianknight89 adrianknight89 commented Jul 19, 2019

@PouryaNoufallah96 You could try using a nightly build by setting your Nuget package source to https://aka.ms/xf-ci/index.json, but I believe this fix hasn't been built yet since the latest nightly has issues still.

Loading

@marunprasadbe13
Copy link

@marunprasadbe13 marunprasadbe13 commented Jul 19, 2019

Could you please confirm whether this fix would be included in any of the upcoming Xamarin.Forms releases ? It is required to resolve all the ListView related issues in Android.

Loading

@PouryaNoufallah96
Copy link

@PouryaNoufallah96 PouryaNoufallah96 commented Jul 20, 2019

even the search handlers item templates has this issue on scrooling :(

Loading

@fpiribauer
Copy link

@fpiribauer fpiribauer commented Jul 22, 2019

@marunprasadbe13 there are already tags for the next service releases. Seems like the relevant commits are included.

Loading

@adrianknight89
Copy link
Contributor

@adrianknight89 adrianknight89 commented Jul 24, 2019

@hartez @PureWeen I just updated to 4.3.0.971-nightly. It fixes my ListView display issues, but ListView scrolling on Android is broken. I have to swipe up and down several times before scrolling can begin (happens 50% of the cases). I'm not sure if the issue is related to this PR.

Edit: Looks like this has to do with the addition of nested scrolling as described here.

Loading

@PureWeen
Copy link
Contributor

@PureWeen PureWeen commented Jul 24, 2019

@adrianknight89 Yea we'll have that one fixed soon.

My other thought was that perhaps you were hitting this issue on the nightly
#6944 (comment)

We're seeing a few of our UI tests locking up right now from that which we'll have resolved here soon

Loading

@PureWeen PureWeen deleted the paymicro/fix-android-layout branch Jul 24, 2019
@samhouts samhouts removed this from the 4.0.0 milestone Aug 1, 2019
@samhouts samhouts added this to the 3.5.0 milestone Aug 1, 2019
@mfeingol
Copy link

@mfeingol mfeingol commented Aug 3, 2019

@samhouts: any idea which release versions will see these fixes?

Thanks.

Loading

@morphinapg
Copy link

@morphinapg morphinapg commented Aug 3, 2019

@mfeingol I installed 4.1.0.618606 and it solved my issues

Loading

@mfeingol
Copy link

@mfeingol mfeingol commented Aug 3, 2019

@morphinapg: thanks! That version does seem to have fixed my issues on Android.

Loading

@jingliancui
Copy link

@jingliancui jingliancui commented Aug 6, 2019

#6889
this bug still not fix in 4.1.0.618606

Loading

@mdmota
Copy link

@mdmota mdmota commented Sep 23, 2019

this bug still not fix in 4.2.0

Loading

@nicolasmab
Copy link

@nicolasmab nicolasmab commented Sep 25, 2019

In 4.2.0, a ListView with RecycleElement, and Images with IsVisible property is still causing images to randomly appear in rows that shouldn't. This occurs after some scrolling, in both iOS and Android. (This was working fine in 3.6)

As a workaround until this is fixed, the IsVisible property can be moved inside an <Image.Trigger>:

From:

<Image Source="comment.png"
       IsVisible="{Binding HasComment}" />

To

<Image Source="comment.png">
    <Image.Triggers>
        <DataTrigger TargetType="Image" Binding="{Binding HasComment}" Value="True">
            <Setter Property="IsVisible" Value="True" />
        </DataTrigger>
        <DataTrigger TargetType="Image" Binding="{Binding HasComment}" Value="False">
            <Setter Property="IsVisible" Value="False" />
        </DataTrigger>
    </Image.Triggers>
</Image>

Loading

@DavidCFreire
Copy link

@DavidCFreire DavidCFreire commented Oct 11, 2019

Any news on that? having same issues here with XF4.0 or XF4.1

Loading

@DavidCFreire
Copy link

@DavidCFreire DavidCFreire commented Oct 12, 2019

I just updated to XF4.3.0.778476-pre1 and apparently this solved the problem... no problems until now

Loading

@mdmota
Copy link

@mdmota mdmota commented Oct 14, 2019

this bug still not fix in XF4.3.0.778476-pre3

Loading

@mdmota
Copy link

@mdmota mdmota commented Oct 24, 2019

After upgrading XF to 4.3.0 and replacing listivew with colletionView, the problem continues
#8199 (comment)

Loading

@SachinCS1992
Copy link

@SachinCS1992 SachinCS1992 commented Oct 29, 2019

This PR seems have to introduced a new issue on Android Editor, where if the Editor lives inside a ScrollView, on first load of Editor we can't select the words to be able to copy/paste/select all text. If we flip device orientation, it fixes the issue. Tried reverting commit locally and re-published a package and that fixed the issue.

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Sprint 154
  
In progress
Sprint 155
  
Continued in next sprint
Sprint 156
  
Done
v3.6.0
  
In Progress
v4.0.0
  
Done
Linked issues

Successfully merging this pull request may close these issues.

None yet