MacOS #650
Merged
MacOS #650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmarinho
removed
the
DO-NOT-MERGE-!!! 🛑
* [macOS] Fixed Tab NSImage crash in TabbedPageRenderer * Coding Style * Coding Style
samhouts
approved these changes
Jan 26, 2017
| @@ -13,6 +13,7 @@ | |||
| [assembly: AssemblyConfiguration("")] | |||
| [assembly: AssemblyCulture("")] | |||
| [assembly: NeutralResourcesLanguage("en")] | |||
| [assembly: InternalsVisibleTo("Xamarin.Forms.Maps.macOS")] | |||
| var textCell = (TextCell)tvc.Cell; | ||
| if (args.PropertyName == TextCell.TextProperty.PropertyName) | ||
| { | ||
| tvc.TextLabel.StringValue = ((TextCell)tvc.Cell).Text ?? ""; |
There was a problem hiding this comment.
Can't you use textCell here instead of casting again?
| } | ||
| else if (args.PropertyName == TextCell.DetailProperty.PropertyName) | ||
| { | ||
| tvc.DetailTextLabel.StringValue = ((TextCell)tvc.Cell).Detail ?? ""; |
There was a problem hiding this comment.
Can't you use textCell here instead of casting again?
|
|
||
| internal NSViewController ViewController => PlatformRenderer; | ||
|
|
||
| internal static void DisposeModelAndChildrenRenderers(Element view) |
There was a problem hiding this comment.
No it's really Model like yourself and children (this is the same on iOS)
| if (rendererToRemove == null || rendererToRemove.Element == null) | ||
| return; | ||
|
|
||
| if (rendererToRemove.Element != null && GetRenderer(rendererToRemove.Element) == rendererToRemove) |
There was a problem hiding this comment.
We already null check rendererToRemove.Element just above this.
|
|
||
| ITemplatedItemsView<Cell> TemplatedItemsView => Element; | ||
|
|
||
| public const int DefaultRowHeight = 44; |
There was a problem hiding this comment.
This says 16 is the default row height for macOS.
| _disposed = true; | ||
| if (Element != null) | ||
| { | ||
| //((ObservableList<string>)Element.Items).CollectionChanged -= RowsCollectionChanged; |
|
|
||
| protected override void SetBackgroundColor(Color color) | ||
| { | ||
| //base.SetBackgroundColor(color); |
| [Export(nameof(UpdateScrollPosition))] | ||
| void UpdateScrollPosition() | ||
| { | ||
| System.Diagnostics.Debug.WriteLine("need to fix this math"); |
There was a problem hiding this comment.
Maybe this should be a todo instead of a debug writeline?
| else | ||
| { | ||
| Control.StringValue = (string)values[1] ?? ""; | ||
| // default value of color documented to be black in iOS docs |
|
I'd recommend putting TODOs on all commented code to make it easier to find. |
knocte
added a commit
to knocte/Xamarin.Forms
that referenced
this pull request
Apr 17, 2017
Support was added in xamarin#650 (xamarin@52fc047)
rmarinho
pushed a commit
that referenced
this pull request
Apr 18, 2017
|
@samhouts you were so right and i forgot , but did it now :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This PR adds support for MacOS backend on Xamarin.Forms.
All the controls are implemented expect OpenGLView, but not all features are present.
We have UITest rudimentary support on CI.
Opening the PR to prepare for review and merge in the following weeks. As well as get general feedback.
Take in mind most renderers are ported from the iOS counterpart and might have some incongruences that we can now fix in this new implementation , please point them out if see them.
Xamarin.Forms.Maps.MacOS.Extra is a extra lib that is only needed to support Cycle 8, it has some missing APIS that were only added to Xamarin.Mac in Cycle9.
Behavioral Changes
Add MacOS backend
PR Checklist