New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put the child view underneath the Navigation Bar when translucent (iOS) #659

Merged
merged 2 commits into from Jan 12, 2017

Conversation

Projects
None yet
5 participants
@skaman
Contributor

skaman commented Dec 21, 2016

Description of Change

Under iOS, only if the Navigation Bar is translucent, the content is placed underneath the Navigation
Bar and not aligned to the bottom.

Bugs Fixed

API Changes

None

Behavioral Changes

Before this patch, if the Navagion Bar was setted to translucent, underneath the navigation bar the user see the background of the navigation controller. After the patch he'll see the child view (on iOS this should be the right behaviour for translucent navigation bar)

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard
  • Consolidate commits as makes sense
@dnfclas

This comment has been minimized.

Show comment
Hide comment
@dnfclas

dnfclas Dec 21, 2016

Hi @skaman, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!

The agreement was validated by .NET Foundation and real humans are currently evaluating your PR.

TTYL, DNFBOT;

dnfclas commented Dec 21, 2016

Hi @skaman, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!

The agreement was validated by .NET Foundation and real humans are currently evaluating your PR.

TTYL, DNFBOT;

@jimmgarrido

This comment has been minimized.

Show comment
Hide comment
@jimmgarrido

jimmgarrido Jan 3, 2017

Collaborator

This is a similar fix as #621

Collaborator

jimmgarrido commented Jan 3, 2017

This is a similar fix as #621

@skaman

This comment has been minimized.

Show comment
Hide comment
@skaman

skaman Jan 3, 2017

Contributor

True, the #621 maybe need also a fix for the container height. If the content go underneath the navigation bar, the height of the navigation bar should not be considered for the container height (it's like the navigation is invisibile and the container fit the screen).

Contributor

skaman commented Jan 3, 2017

True, the #621 maybe need also a fix for the container height. If the content go underneath the navigation bar, the height of the navigation bar should not be considered for the container height (it's like the navigation is invisibile and the container fit the screen).

@rmarinho

This comment has been minimized.

Show comment
Hide comment
@rmarinho

rmarinho Jan 4, 2017

Member

@jimmgarrido can you check if this is covered by #621 if so we can close this one.

Member

rmarinho commented Jan 4, 2017

@jimmgarrido can you check if this is covered by #621 if so we can close this one.

@jimmgarrido

This comment has been minimized.

Show comment
Hide comment
@jimmgarrido

jimmgarrido Jan 11, 2017

Collaborator

@rmarinho @skaman #621 does not adjust the container's size for this change and results in an empty area below the page content. #621 should be closed in favor of this pull request.

Collaborator

jimmgarrido commented Jan 11, 2017

@rmarinho @skaman #621 does not adjust the container's size for this change and results in an empty area below the page content. #621 should be closed in favor of this pull request.

@rmarinho rmarinho merged commit f81e41b into xamarin:master Jan 12, 2017

6 checks passed

Android-UITests-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle 8 :: UI Tests :: OSX Test Cloud Package - Run Android 6.0.1 : Tests passed: 351, i…
Details
OSX-Debug-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle 8 :: OSX Debug : Running
Details
Windows-Debug-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle 8 :: Windows Debug : Tests passed: 3685, ignored: 10
Details
iOS10-UITests-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle 8 :: UI Tests :: OSX Test Cloud Package - Run iOS Unified iOS10 : Tests passed: 34…
Details
iOS8-UITests-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle 8 :: UI Tests :: OSX Test Cloud Package - Run iOS Unified IOS8 : Tests passed: 344…
Details
iOS9-UITests-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle 8 :: UI Tests :: OSX Test Cloud Package - Run iOS Unified iOS9 : Tests passed: 346…
Details

@samhouts samhouts added this to the 2.3.4 milestone Jun 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment