New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't create FontExtensions Regex unless/until necessary #676

merged 2 commits into from Jan 11, 2017


None yet
4 participants

hartez commented Jan 11, 2017

Description of Change

Defers the creation of the regex used to determine whether the font needs to be loaded from an assset. Reduces overhead if no font with a FontFamily property is ever used in the application.

Bugs Fixed

  • None

API Changes

  • None

Behavioral Changes

  • None

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard
  • Consolidate commits as makes sense

hartez added some commits Jan 11, 2017

@jassmith jassmith merged commit 1d58aae into master Jan 11, 2017

2 of 3 checks passed

Android-UITests-C8 Started TeamCity Build Xamarin.Forms :: Debug :: Cycle 8 :: UI Tests :: OSX Test Cloud Package - Run Android 6.0.1
OSX-Debug-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle 8 :: OSX Debug : Running
Windows-Debug-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle 8 :: Windows Debug : Tests passed: 3695, ignored: 10

@hartez hartez deleted the fontextensions-lazy-regex branch May 16, 2017

@samhouts samhouts added this to the 2.3.4 milestone Jun 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment