New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move XF.ConcurrentDictionary to WP8 project #685

Merged
merged 1 commit into from Jan 23, 2017

Conversation

Projects
None yet
4 participants
@hartez
Member

hartez commented Jan 17, 2017

Description of Change

Forms has its own version of ConcurrentDictionary<TKey, TValue> in order to support platforms which don't have a ConcurrentDictionary available. At this point, the only platform without a ConcurrentDictionary available is Windows Phone 8. For all of the other platforms, the ConcurrentDictionary available in .NET/Mono is already being used to support other classes, which means that during startup both versions of the class are being JIT-compiled.

This change moves the Forms version of ConcurrentDictionary into the Windows Phone 8 platform project and switches to the .NET/Mono ConcurrentDictionary in the other platforms. This avoids the extra JIT compilation cost (e.g., ~160 ms on a Nexus 6) for the non-WP8 platforms and in the long term will reduce the number of classes Forms needs to maintain.

Bugs Fixed

  • None

API Changes

None

Behavioral Changes

None

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard
  • Consolidate commits as makes sense

@hartez hartez merged commit c468302 into master Jan 23, 2017

6 checks passed

Android-UITests-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle 8 :: UI Tests :: OSX Test Cloud Package - Run Android 6.0.1 : Tests passed: 351, i…
Details
OSX-Debug-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle 8 :: OSX Debug : Running
Details
Windows-Debug-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle 8 :: Windows Debug : Tests passed: 3697, ignored: 10
Details
iOS10-UITests-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle 8 :: UI Tests :: OSX Test Cloud Package - Run iOS Unified iOS10 : Tests passed: 34…
Details
iOS8-UITests-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle 8 :: UI Tests :: OSX Test Cloud Package - Run iOS Unified IOS8 : Tests passed: 345…
Details
iOS9-UITests-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle 8 :: UI Tests :: OSX Test Cloud Package - Run iOS Unified iOS9 : Tests passed: 347…
Details

@hartez hartez deleted the single-concurrent-dictionary branch May 16, 2017

@samhouts samhouts added D-15.4 and removed cla-already-signed labels Oct 10, 2017

@samhouts samhouts added this to the 2.3.5 milestone Jun 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment