New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] Remove "Enabled" usage on AdjustsFontSizeToFitWidth #696

Merged
merged 2 commits into from Jan 30, 2017

Conversation

Projects
None yet
5 participants
@pauldipietro
Member

pauldipietro commented Jan 17, 2017

Description of Change

There was lingering usage of "Enabled" in naming from #526. This corrects those names while we should still be able to since this is only in 2.3.4-pre1.

Bugs Fixed

N/A

API Changes

See changes

Behavioral Changes

N/A

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard
  • Consolidate commits as makes sense
@rmarinho

This is a breaking change and needs docs update. When did we ship this API the 1st time?

@samhouts

With docs update

@pauldipietro

This comment has been minimized.

Show comment
Hide comment
@pauldipietro

pauldipietro Jan 28, 2017

Member

Docs updated. @rmarinho this is only in 2.3.4-pre1

Member

pauldipietro commented Jan 28, 2017

Docs updated. @rmarinho this is only in 2.3.4-pre1

@rmarinho rmarinho merged commit 6296c44 into master Jan 30, 2017

6 checks passed

Android-UITests-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle 8 :: UI Tests :: OSX Test Cloud Package - Run Android 6.0.1 : Tests passed: 352, i…
Details
OSX-Debug-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle 8 :: OSX Debug : Running
Details
Windows-Debug-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle 8 :: Windows Debug : Tests passed: 3719, ignored: 10
Details
iOS10-UITests-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle 8 :: UI Tests :: OSX Test Cloud Package - Run iOS Unified iOS10 : Tests passed: 34…
Details
iOS8-UITests-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle 8 :: UI Tests :: OSX Test Cloud Package - Run iOS Unified IOS8 : Tests passed: 348…
Details
iOS9-UITests-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle 8 :: UI Tests :: OSX Test Cloud Package - Run iOS Unified iOS9 : Tests passed: 350…
Details

rmarinho added a commit that referenced this pull request Jan 30, 2017

[iOS] Remove "Enabled" usage on AdjustsFontSizeToFitWidth (#696)
* [iOS] Remove "Enabled" usage on AdjustsFontSizeToFitWidth

* Update docs

@rmarinho rmarinho deleted the ios-ps-naming branch Jun 22, 2017

@samhouts samhouts added this to the 2.3.4 milestone Jun 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment