New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[XamlC] Produce correct mdb files #699

Merged
merged 12 commits into from Feb 2, 2017

Conversation

Projects
None yet
2 participants
@StephaneDelcroix
Member

StephaneDelcroix commented Jan 18, 2017

Description of Change

  • Update to cecil 0.10.0-beta
  • no longer duplicate methods (used to mess with sequence_points matching)
  • force using symbol reader and writers
  • allow debugging of Xamarin.Forms.Xaml.UnitTests

I can't automate easily the check making sure the mdb file is modified, and correct. But as our relationship is based on trust, that's ok.

Bugs Fixed

API Changes

/

Behavioral Changes

/

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard
  • Consolidate commits as makes sense

@StephaneDelcroix StephaneDelcroix changed the title from Xamlc debug to [XamlC] Produce correct mdb files Jan 20, 2017

@StephaneDelcroix StephaneDelcroix referenced this pull request Jan 20, 2017

Closed

Fix debugging tests #694

4 of 4 tasks complete
using (var assemblyDefinition = AssemblyDefinition.ReadAssembly(Assembly, new ReaderParameters {
ReadWrite = true,
ReadSymbols = DebugSymbols,
SymbolReaderProvider = System.Type.GetType("Mono.Runtime") != null ? ((ISymbolReaderProvider)(new MdbReaderProvider())) : ((ISymbolReaderProvider)new PdbReaderProvider()),

This comment has been minimized.

@StephaneDelcroix

StephaneDelcroix Jan 20, 2017

Member

this should be set only if DebugSymbols is true (same for the 3 others spots)

@StephaneDelcroix

StephaneDelcroix Jan 20, 2017

Member

this should be set only if DebugSymbols is true (same for the 3 others spots)

This comment has been minimized.

@StephaneDelcroix

StephaneDelcroix Jan 23, 2017

Member

doesn't matter in this file. fixed in the other

@StephaneDelcroix

StephaneDelcroix Jan 23, 2017

Member

doesn't matter in this file. fixed in the other

@StephaneDelcroix StephaneDelcroix requested a review from jassmith Jan 24, 2017

@StephaneDelcroix StephaneDelcroix referenced this pull request Jan 27, 2017

Merged

[XamlC] support portable pdb #726

4 of 4 tasks complete
@StephaneDelcroix

This comment has been minimized.

Show comment
Hide comment
@StephaneDelcroix

StephaneDelcroix Feb 1, 2017

Member

This has the nasty side effects of never invoking the compiled version of InitializeComponent :(

FIXED

Member

StephaneDelcroix commented Feb 1, 2017

This has the nasty side effects of never invoking the compiled version of InitializeComponent :(

FIXED

StephaneDelcroix added some commits Jan 12, 2017

f
fix

@StephaneDelcroix StephaneDelcroix merged commit fa08821 into master Feb 2, 2017

1 of 6 checks passed

Android-UITests-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle 8 :: UI Tests :: OSX Test Cloud Package - Run Android 6.0.1 : Canceled (Snapshot d…
Details
iOS10-UITests-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle 8 :: UI Tests :: OSX Test Cloud Package - Run iOS Unified iOS10 : Canceled (Snapsh…
Details
iOS8-UITests-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle 8 :: UI Tests :: OSX Test Cloud Package - Run iOS Unified IOS8 : Canceled (Snapsho…
Details
iOS9-UITests-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle 8 :: UI Tests :: OSX Test Cloud Package - Run iOS Unified iOS9 : Canceled (Snapsho…
Details
OSX-Debug-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle 8 :: OSX Debug : Exit code 1
Details
Windows-Debug-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle 8 :: Windows Debug : Tests passed: 3726, ignored: 10
Details

@StephaneDelcroix StephaneDelcroix deleted the xamlc-debug branch Feb 2, 2017

StephaneDelcroix added a commit that referenced this pull request Mar 1, 2017

[XamlC] Produce correct mdb files (#699)
* [XamlC] change MockCompile (internal) API

* [XamlC] fix debugging in unit test project

* f

* [XamlC] update cecil to 0.10.0-beta1-v2

* beta2

* avoid method duplication

* [XamlC] force loading MdbReader and Writer

* [XamlC] force use the writer in the other task too

* [XamlC] fix test and test code generator

* try building this

* [XamlC] Ensure InitializeComponent is correctly routed

* fix

jassmith added a commit that referenced this pull request Mar 1, 2017

Xamlc ppdb backport (#792)
* [XamlC] Produce correct mdb files (#699)

* [XamlC] change MockCompile (internal) API

* [XamlC] fix debugging in unit test project

* f

* [XamlC] update cecil to 0.10.0-beta1-v2

* beta2

* avoid method duplication

* [XamlC] force loading MdbReader and Writer

* [XamlC] force use the writer in the other task too

* [XamlC] fix test and test code generator

* try building this

* [XamlC] Ensure InitializeComponent is correctly routed

* fix

* [XamlC] support portable pdb (#726)

* [XamlC] update to cecil 0.10.0-b4 to better symbol detection (#791)

@samhouts samhouts added D-15.4 and removed cla-not-required labels Oct 10, 2017

@samhouts samhouts added this to the 2.3.5 milestone Jun 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment