New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[A]Fix potential crash when calling ClearFocus in SearchBarRenderer #700

Merged
merged 1 commit into from Jan 21, 2017

Conversation

Projects
None yet
6 participants
@jassmith
Member

jassmith commented Jan 18, 2017

Description of Change

Adds a try/catch around API that fails in previewer specific situation.

Bugs Fixed

None

API Changes

None

Behavioral Changes

Works now with previewer

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard
  • Consolidate commits as makes sense
}
catch (Java.Lang.UnsupportedOperationException)
{
// silently catch these as they happen in the previewer due to some bugs in upstread android

This comment has been minimized.

@StephaneDelcroix

StephaneDelcroix Jan 18, 2017

Member

upstream

@StephaneDelcroix

StephaneDelcroix Jan 18, 2017

Member

upstream

@rmarinho rmarinho merged commit 0282aae into master Jan 21, 2017

3 checks passed

Android-UITests-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle 8 :: UI Tests :: OSX Test Cloud Package - Run Android 6.0.1 : Tests passed: 351, i…
Details
OSX-Debug-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle 8 :: OSX Debug : Running
Details
Windows-Debug-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle 8 :: Windows Debug : Tests passed: 3697, ignored: 10
Details

@rmarinho rmarinho deleted the clearfocus-crash-fix branch Jan 21, 2017

@alanmcgovern

This comment has been minimized.

Show comment
Hide comment
@alanmcgovern

alanmcgovern Mar 27, 2017

Contributor

Can we get this backported to 2.3.4?

Contributor

alanmcgovern commented Mar 27, 2017

Can we get this backported to 2.3.4?

rmarinho added a commit that referenced this pull request Mar 27, 2017

@rmarinho

This comment has been minimized.

Show comment
Hide comment
@rmarinho

rmarinho Mar 27, 2017

Member

done @alanmcgovern should go on 2.3.4-pre6

Member

rmarinho commented Mar 27, 2017

done @alanmcgovern should go on 2.3.4-pre6

@alanmcgovern

This comment has been minimized.

Show comment
Hide comment
@alanmcgovern

alanmcgovern Mar 27, 2017

Contributor

Gracias!

Contributor

alanmcgovern commented Mar 27, 2017

Gracias!

@samhouts samhouts added this to the 2.3.4 milestone Jun 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment