New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core] Fix NullReferenceException in VisualElement finalizer. #701

Merged
merged 1 commit into from Jan 19, 2017

Conversation

Projects
None yet
4 participants
@kvpt
Contributor

kvpt commented Jan 18, 2017

Description of Change

When EventTrigger, DataTrigger or MultiTrigger are attached to a VisualElement, the finalizer throw a NullReferenceException which crash the application after the page disappear.
It's because these inherit from TriggerBase and not Trigger.

Bugs Fixed

API Changes

Nothing

Behavioral Changes

Describe any non-bug related behavioral changes that may change how users app behaves when upgrading to this version of the codebase.

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard
  • Consolidate commits as makes sense
@dnfclas

This comment has been minimized.

Show comment
Hide comment
@dnfclas

dnfclas Jan 18, 2017

Hi @kvpt, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!

The agreement was validated by .NET Foundation and real humans are currently evaluating your PR.

TTYL, DNFBOT;

dnfclas commented Jan 18, 2017

Hi @kvpt, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!

The agreement was validated by .NET Foundation and real humans are currently evaluating your PR.

TTYL, DNFBOT;

@StephaneDelcroix

This comment has been minimized.

Show comment
Hide comment
@StephaneDelcroix

StephaneDelcroix Jan 19, 2017

Member

Excellent catch, thank you

Member

StephaneDelcroix commented Jan 19, 2017

Excellent catch, thank you

@StephaneDelcroix StephaneDelcroix merged commit a11e4c6 into xamarin:master Jan 19, 2017

@samhouts samhouts referenced this pull request Mar 22, 2017

Merged

[C] detach Behaviors and Triggers on VE finalization #555

4 of 4 tasks complete

@samhouts samhouts added this to the 2.3.4 milestone Jun 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment