Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use XF Size instead of Android.Util.Size #7033

Merged
merged 1 commit into from Aug 1, 2019

Conversation

@hartez
Copy link
Member

hartez commented Jul 31, 2019

Description of Change

Replaces use of Android.Util.Size (not available until API 21) with Xamarin.Forms.Size to avoid missing class definition crashes on API < 21.

Also fixes transposed parameters when using ItemSizingStrategy.MeasureFirstItem.

Issues Resolved

API Changes

None

Platforms Affected

  • Android

Behavioral/Visual Changes

None

Before/After Screenshots

Not applicable

Testing Procedure

Launch Control Gallery on API 19, navigate to
CollectionView Gallery -> Item Sizing Gallery -> Item Sizing Strategies. Should no longer crash.

PR Checklist

  • Has automated tests
  • Rebased on top of the target branch at time of PR
  • Changes adhere to coding standard
…< 21

Fixes #6815
@rmarinho rmarinho merged commit 1d362ad into 4.2.0 Aug 1, 2019
14 of 17 checks passed
14 of 17 checks passed
VSTS: Android API28 Validation Fast Renderers UITests Finished
Details
VSTS: Android API28 Validation Legacy Renderers UITests Finished
Details
VSTS: Android API23 Validation Legacy Renderers UITests Running
Details
VSTS: Android API19 Validation Fast Renderers UITests Finished
Details
VSTS: Android API23 Validation Fast Renderers UITests Finished
Details
VSTS: Android API25 Validation Fast Renderers UITests Finished
Details
VSTS: iOS10 Validation UITests Finished
Details
VSTS: iOS11 Validation UITests Finished
Details
VSTS: iOS12 Validation UITests Finished
Details
Xamarin Forms Build #4.2.0.2902568+37-sha.2ca5a38f-azdo.2902568 succeeded
Details
Xamarin Forms (Build Windows Phase Debug,any cpu) Build Windows Phase Debug,any cpu succeeded
Details
Xamarin Forms (Nuget Phase) Nuget Phase succeeded
Details
Xamarin Forms (OSX Phase) OSX Phase succeeded
Details
Xamarin Forms (Prepare Build Phase) Prepare Build Phase succeeded
Details
Xamarin Forms (Test Phase Debug) Test Phase Debug succeeded
Details
license/cla All CLA requirements met.
Details
xamarin-forms-ci #4.2.0.1467+0-pr.7033-sha.d6080b5c-azdo.4888 succeeded
Details
v4.2.0 automation moved this from In Review to Done Aug 1, 2019
@jfversluis jfversluis deleted the fix-gh6815 branch Aug 1, 2019
@samhouts samhouts added this to the 4.2.0 milestone Aug 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.