[Xaml] do not set properties with private setters #717

Merged
merged 1 commit into from Feb 2, 2017

Conversation

Projects
None yet
5 participants
@StephaneDelcroix
Member

StephaneDelcroix commented Jan 25, 2017

Description of Change

[Xaml] do not set properties with private setters

Bugs Fixed

API Changes

/

Behavioral Changes

/

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard
  • Consolidate commits as makes sense
@@ -422,7 +422,7 @@ static bool TrySetValue(object element, BindableProperty property, bool attached
return false;
}
- static bool TrySetProperty(object element, string localName, object value, IXmlLineInfo lineInfo, XamlServiceProvider serviceProvider, out Exception exception)
+ static bool TrySetProperty(object element, string localName, object value, IXmlLineInfo lineInfo, XamlServiceProvider serviceProvider, HydratationContext context, out Exception exception)

This comment has been minimized.

@hartez

hartez Jan 27, 2017

Member

TIL that 'hydratation' is French for 'hydration'.

@hartez

hartez Jan 27, 2017

Member

TIL that 'hydratation' is French for 'hydration'.

This comment has been minimized.

@StephaneDelcroix

StephaneDelcroix Jan 28, 2017

Member

at this point I can't even remember which is which

@StephaneDelcroix

StephaneDelcroix Jan 28, 2017

Member

at this point I can't even remember which is which

+ xmlns:local="clr-namespace:Xamarin.Forms.Xaml.UnitTests"
+ x:Class="Xamarin.Forms.Xaml.UnitTests.Bz44216">
+ <ContentPage.Behaviors>
+ <local:Bz44216Behavior MinLengh="5" />

This comment has been minimized.

@hartez

hartez Jan 27, 2017

Member

MinLengh -> MinLength
Leaving it up to you whether you feel like fixing it.

@hartez

hartez Jan 27, 2017

Member

MinLengh -> MinLength
Leaving it up to you whether you feel like fixing it.

This comment has been minimized.

@StephaneDelcroix

StephaneDelcroix Jan 28, 2017

Member

the typo were on purpose, as provided in the original sample (sic)

@StephaneDelcroix

StephaneDelcroix Jan 28, 2017

Member

the typo were on purpose, as provided in the original sample (sic)

@hartez

hartez approved these changes Jan 27, 2017

@StephaneDelcroix StephaneDelcroix merged commit 750b034 into master Feb 2, 2017

1 of 2 checks passed

OSX-Debug-C8 Started TeamCity Build Xamarin.Forms :: Debug :: Cycle 8 :: OSX Debug
Details
Windows-Debug-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle 8 :: Windows Debug : Tests passed: 3733, ignored: 10
Details

@StephaneDelcroix StephaneDelcroix deleted the fix-bz44216 branch Feb 2, 2017

@samhouts samhouts added D-15.4 and removed cla-already-signed labels Oct 10, 2017

@samhouts samhouts added this to the 2.3.5 milestone Jun 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment