New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] Fix extra tab icon appearing in iOS for TabbedPage (was #448) #720

Merged
merged 3 commits into from Feb 17, 2017

Conversation

Projects
None yet
4 participants
@StephaneDelcroix
Member

StephaneDelcroix commented Jan 26, 2017

Description of Change

[iOS] Fix extra tab icon appearing in iOS for TabbedPage

This branch pull #448 along, and add a test.

DO NOT SQUASH-MERGE TO PRESERVE AUTHOR ATTRIBUTION

This adds a workaround for an iOS 10 bug that displays extra icons in a UITabBarController when the UITabBarItem.Title property is changed. More info here: http://stackoverflow.com/questions/38776978/ios-10-uitabbar-more-items-visible-after-setting-title

Bugs Fixed

API Changes

Added:

  • internal Forms.IsiOS10OrNewer { get; }

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard
  • Consolidate commits as makes sense

Chad Kimes and others added some commits Jan 26, 2017

[iOS] Fix extra tab icon appearing in iOS for TabbedPage (#448)
commit 1ba6ff67a745a0e802f67b7a4f36db4f8385466e
Merge: e3f1937 a1d4b64
Author: Stephane Delcroix <stephane@delcroix.org>
Date:   Thu Jan 26 10:11:08 2017 +0100

    Merge branch 'master' of git://github.com/ckimes89/Xamarin.Forms into ckimes89-master

commit a1d4b64
Author: Chad Kimes <chad.kimes@iticentral.com>
Date:   Tue Oct 11 13:42:28 2016 -0400

    [iOS] Fix extra tab icon appearing in iOS 10

commit 07cd17d
Author: Chad Kimes <chad.kimes@iticentral.com>
Date:   Tue Oct 11 13:38:30 2016 -0400

    [iOS] Add static check method for iOS 10

@rmarinho rmarinho merged commit a1c7f99 into master Feb 17, 2017

6 checks passed

Android-UITests-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle 8 :: UI Tests :: OSX Test Cloud Package - Run Android 6.0.1 : Tests passed: 352, i…
Details
OSX-Debug-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle 8 :: OSX Debug : Running
Details
Windows-Debug-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle 8 :: Windows Debug : Tests passed: 3715, ignored: 10
Details
iOS10-UITests-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle 8 :: UI Tests :: OSX Test Cloud Package - Run iOS Unified iOS10 : Tests passed: 34…
Details
iOS8-UITests-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle 8 :: UI Tests :: OSX Test Cloud Package - Run iOS Unified IOS8 : Tests passed: 346…
Details
iOS9-UITests-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle 8 :: UI Tests :: OSX Test Cloud Package - Run iOS Unified iOS9 : Tests passed: 348…
Details

@rmarinho rmarinho deleted the re-448 branch Jun 22, 2017

@samhouts samhouts added D-15.4 and removed cla-already-signed labels Oct 10, 2017

@samhouts samhouts added this to the 2.3.5 milestone Jul 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment