[XamlC] support portable pdb #726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephaneDelcroix
force-pushed
the
fix-bz51778
branch
from
5503c95
to
786b153
Compare
|
Cecil now supports this officially and even simpler code can be used. See jbevain/cecil#322 for more details |
|
@marek-safar I know, but for some reason cecil can't find the symbol assembly at runtime using reflection while being used in our task. This is the reason why we manually reference the symbol reader providers... |
|
Do you have the exception with the type it cannot find? |
4 tasks
StephaneDelcroix
added a commit
that referenced
this pull request
Mar 1, 2017
jassmith
pushed a commit
that referenced
this pull request
Mar 1, 2017
* [XamlC] Produce correct mdb files (#699) * [XamlC] change MockCompile (internal) API * [XamlC] fix debugging in unit test project * f * [XamlC] update cecil to 0.10.0-beta1-v2 * beta2 * avoid method duplication * [XamlC] force loading MdbReader and Writer * [XamlC] force use the writer in the other task too * [XamlC] fix test and test code generator * try building this * [XamlC] Ensure InitializeComponent is correctly routed * fix * [XamlC] support portable pdb (#726) * [XamlC] update to cecil 0.10.0-b4 to better symbol detection (#791)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
[XamlC] support portable pdb. Reuse Cecil logic (dotnet/cecil@898fb6b#diff-d60c9973465fb52c71c5ba9af324992aR687) based on file availability to pick between Pdb (portable or native) or Mdb.
Portable Pdb will be the default symbol format for mono in Cycle10. We HAVE to support this.
This PR actually contains a single commit but is built on top of #699. Merge that one before.Bugs Fixed
API Changes
/
Behavioral Changes
/
PR Checklist