New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[XamlC] support portable pdb #726

Merged
merged 1 commit into from Feb 6, 2017

Conversation

Projects
None yet
4 participants
@StephaneDelcroix
Member

StephaneDelcroix commented Jan 27, 2017

Description of Change

[XamlC] support portable pdb. Reuse Cecil logic (mono/cecil@898fb6b#diff-d60c9973465fb52c71c5ba9af324992aR687) based on file availability to pick between Pdb (portable or native) or Mdb.

Portable Pdb will be the default symbol format for mono in Cycle10. We HAVE to support this.

This PR actually contains a single commit but is built on top of #699. Merge that one before.

Bugs Fixed

API Changes

/

Behavioral Changes

/

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard
  • Consolidate commits as makes sense

@StephaneDelcroix StephaneDelcroix merged commit bfb5de5 into master Feb 6, 2017

6 checks passed

Android-UITests-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle 8 :: UI Tests :: OSX Test Cloud Package - Run Android 6.0.1 : Tests passed: 352, i…
Details
OSX-Debug-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle 8 :: OSX Debug : Running
Details
Windows-Debug-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle 8 :: Windows Debug : Tests passed: 3733, ignored: 10
Details
iOS10-UITests-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle 8 :: UI Tests :: OSX Test Cloud Package - Run iOS Unified iOS10 : Tests passed: 34…
Details
iOS8-UITests-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle 8 :: UI Tests :: OSX Test Cloud Package - Run iOS Unified IOS8 : Tests passed: 348…
Details
iOS9-UITests-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle 8 :: UI Tests :: OSX Test Cloud Package - Run iOS Unified iOS9 : Tests passed: 350…
Details

@StephaneDelcroix StephaneDelcroix deleted the fix-bz51778 branch Feb 6, 2017

@marek-safar

This comment has been minimized.

Show comment
Hide comment
@marek-safar

marek-safar Feb 23, 2017

Cecil now supports this officially and even simpler code can be used. See jbevain/cecil#322 for more details

marek-safar commented Feb 23, 2017

Cecil now supports this officially and even simpler code can be used. See jbevain/cecil#322 for more details

@StephaneDelcroix

This comment has been minimized.

Show comment
Hide comment
@StephaneDelcroix

StephaneDelcroix Feb 23, 2017

Member

@marek-safar I know, but for some reason cecil can't find the symbol assembly at runtime using reflection while being used in our task. This is the reason why we manually reference the symbol reader providers...

Member

StephaneDelcroix commented Feb 23, 2017

@marek-safar I know, but for some reason cecil can't find the symbol assembly at runtime using reflection while being used in our task. This is the reason why we manually reference the symbol reader providers...

@marek-safar

This comment has been minimized.

Show comment
Hide comment
@marek-safar

marek-safar Feb 23, 2017

Do you have the exception with the type it cannot find?

marek-safar commented Feb 23, 2017

Do you have the exception with the type it cannot find?

StephaneDelcroix added a commit that referenced this pull request Mar 1, 2017

jassmith added a commit that referenced this pull request Mar 1, 2017

Xamlc ppdb backport (#792)
* [XamlC] Produce correct mdb files (#699)

* [XamlC] change MockCompile (internal) API

* [XamlC] fix debugging in unit test project

* f

* [XamlC] update cecil to 0.10.0-beta1-v2

* beta2

* avoid method duplication

* [XamlC] force loading MdbReader and Writer

* [XamlC] force use the writer in the other task too

* [XamlC] fix test and test code generator

* try building this

* [XamlC] Ensure InitializeComponent is correctly routed

* fix

* [XamlC] support portable pdb (#726)

* [XamlC] update to cecil 0.10.0-b4 to better symbol detection (#791)

@samhouts samhouts added D15.4 and removed cla-already-signed labels Oct 10, 2017

@samhouts samhouts modified the milestone: 3.1.0 Jun 1, 2018

@samhouts samhouts modified the milestones: 2.3.0, 2.3.5 Jun 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment