[WinRT/UWP] Fix Slider binding value incorrectly #729

Merged
merged 1 commit into from Jan 31, 2017

Conversation

Projects
None yet
6 participants
@pauldipietro
Member

pauldipietro commented Jan 27, 2017

Description of Change

A bound initial value on a slider was not working on WinRT/UWP if the Minimum value was not set to 0. it appears that not setting these values on the control prior to assigning OnNativeValueChanged is incorrectly setting Element.Value to Minimum. Adjusting the sequence allows the behavior to function as expected.

(While it was noticed, a small adjustment was made to remove an unnecessarily extra capital letter in OnNativeValueChanged.)

Bugs Fixed

https://bugzilla.xamarin.com/show_bug.cgi?id=41619

API Changes

None

Behavioral Changes

None

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard
  • Consolidate commits as makes sense
@rmarinho

This comment has been minimized.

Show comment
Hide comment
@rmarinho

rmarinho Jan 31, 2017

Member

Failing iOS tests are not related..

Member

rmarinho commented Jan 31, 2017

Failing iOS tests are not related..

@rmarinho rmarinho merged commit d80be6f into master Jan 31, 2017

4 of 6 checks passed

iOS10-UITests-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle 8 :: UI Tests :: OSX Test Cloud Package - Run iOS Unified iOS10 : Tests failed: 16…
Details
Android-UITests-C8 Started TeamCity Build Xamarin.Forms :: Debug :: Cycle 8 :: UI Tests :: OSX Test Cloud Package - Run Android 6.0.1
Details
OSX-Debug-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle 8 :: OSX Debug : Running
Details
Windows-Debug-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle 8 :: Windows Debug : Tests passed: 3717, ignored: 10
Details
iOS8-UITests-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle 8 :: UI Tests :: OSX Test Cloud Package - Run iOS Unified IOS8 : Tests passed: 348…
Details
iOS9-UITests-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle 8 :: UI Tests :: OSX Test Cloud Package - Run iOS Unified iOS9 : Tests passed: 350…
Details

@rmarinho rmarinho deleted the fix-bugzilla41619 branch Jun 22, 2017

@iupchris10

This comment has been minimized.

Show comment
Hide comment
@iupchris10

iupchris10 Aug 23, 2017

Is this fix available in Xamarin Forms yet? In any pre-releases?

Is this fix available in Xamarin Forms yet? In any pre-releases?

@pauldipietro

This comment has been minimized.

Show comment
Hide comment
@pauldipietro

pauldipietro Aug 23, 2017

Member

@iupchris10 This should be available in the 2.4.0 prerelease, which was a continuation of the 2.3.5 prereleases (which we decided to turn into 2.4).

Member

pauldipietro commented Aug 23, 2017

@iupchris10 This should be available in the 2.4.0 prerelease, which was a continuation of the 2.3.5 prereleases (which we decided to turn into 2.4).

@iupchris10

This comment has been minimized.

Show comment
Hide comment
@iupchris10

iupchris10 Aug 23, 2017

Thanks @pauldipietro! I fetched 2.4.0.266-pre1 and the issue is fixed for me.

Thanks @pauldipietro! I fetched 2.4.0.266-pre1 and the issue is fixed for me.

@samhouts samhouts added D-15.4 and removed cla-not-required labels Oct 10, 2017

@samhouts samhouts modified the milestone: 3.1.0 Jun 1, 2018

@samhouts samhouts added this to Done in vNext+1 (master) Jun 26, 2018

@samhouts samhouts removed this from Done in vNext+1 (master) Jun 26, 2018

@samhouts samhouts modified the milestones: 2.3.0, 2.3.5 Jun 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment