New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix disappearing ListView text when changing color settings on Windows #731

Merged
merged 4 commits into from Feb 3, 2017

Conversation

Projects
None yet
4 participants
@hartez
Member

hartez commented Jan 31, 2017

Description of Change

Modified the WrapperControl class which hosts ViewCell to inherit from Canvas rather than ContentControl; it now responds correctly to color preferences changes.

This modification also fixes the problems reported in 32847, so the ugly hacks previously used to fix those issues (the IWrapperAware interface and several event listeners attached directly to the individual components of DatePicker and TimePicker) are no longer necessary.

Bugs Fixed

API Changes

None

Behavioral Changes

None

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard
  • Consolidate commits as makes sense

hartez added some commits Jan 30, 2017

@hartez hartez requested review from rmarinho and samhouts Feb 1, 2017

@samhouts samhouts merged commit 5af224a into master Feb 3, 2017

6 checks passed

Android-UITests-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle 8 :: UI Tests :: OSX Test Cloud Package - Run Android 6.0.1 : Tests passed: 352, i…
Details
OSX-Debug-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle 8 :: OSX Debug : Running
Details
Windows-Debug-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle 8 :: Windows Debug : Tests passed: 3719, ignored: 10
Details
iOS10-UITests-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle 8 :: UI Tests :: OSX Test Cloud Package - Run iOS Unified iOS10 : Tests passed: 34…
Details
iOS8-UITests-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle 8 :: UI Tests :: OSX Test Cloud Package - Run iOS Unified IOS8 : Tests passed: 348…
Details
iOS9-UITests-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle 8 :: UI Tests :: OSX Test Cloud Package - Run iOS Unified iOS9 : Tests passed: 350…
Details

@samhouts samhouts deleted the fix-bugzilla40139 branch Feb 3, 2017

rmarinho added a commit that referenced this pull request Jul 28, 2017

Fix disappearing ListView text when changing color settings on Windows (
#731)

* repro

* Checkpoint

* Checkpoint

* Remove now-unnecessary hacks for Time- and DatePicker

@samhouts samhouts added D-15.4 and removed cla-not-required labels Oct 10, 2017

@pauldipietro pauldipietro referenced this pull request Oct 17, 2017

Merged

[UWP] Inherit from Panel on WrapperControl #1204

3 of 4 tasks complete

@samhouts samhouts modified the milestone: 3.1.0 Jun 1, 2018

@samhouts samhouts added this to Done in vNext+1 (master) Jun 26, 2018

@samhouts samhouts removed this from Done in vNext+1 (master) Jun 26, 2018

@samhouts samhouts modified the milestones: 2.3.0, 2.3.5 Jun 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment