New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xaml empty service provider #736

Merged
merged 3 commits into from Feb 10, 2017

Conversation

Projects
None yet
4 participants
@StephaneDelcroix
Member

StephaneDelcroix commented Feb 1, 2017

Description of Change

Do not generate ServiceProvider if they're not used in Custom MarkupExtensions.

Bugs Fixed

API Changes

Added:

[AttributeUsage(AttributeTargets.Class, Inherited = false)]
public sealed class AcceptEmptyServiceProviderAttribute : Attribute

Behavioral Changes

/

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard
  • Consolidate commits as makes sense
@jonathanpeppers

This comment has been minimized.

Show comment
Hide comment
@jonathanpeppers

jonathanpeppers Feb 1, 2017

Contributor

@StephaneDelcroix I had to merge several of your PRs to try this as we were on top of 2.3.3.

At first glance, it seems our compiled binary went down about 6MB after putting [AcceptEmptyServiceProvider] on several of our markup extensions. Then I added back ARMv7 and our app is once again working on 32 bit.

There is one thing in our codebase that is getting an error in XamlC now, but we are messing with it to figure out what is wrong. We also need to QA the app in general to make sure nothing broke.

Are there more XamlC changes in 2.3.4 that would mean we should upgrade?

Contributor

jonathanpeppers commented Feb 1, 2017

@StephaneDelcroix I had to merge several of your PRs to try this as we were on top of 2.3.3.

At first glance, it seems our compiled binary went down about 6MB after putting [AcceptEmptyServiceProvider] on several of our markup extensions. Then I added back ARMv7 and our app is once again working on 32 bit.

There is one thing in our codebase that is getting an error in XamlC now, but we are messing with it to figure out what is wrong. We also need to QA the app in general to make sure nothing broke.

Are there more XamlC changes in 2.3.4 that would mean we should upgrade?

@jonathanpeppers

This comment has been minimized.

Show comment
Hide comment
@jonathanpeppers

jonathanpeppers Feb 7, 2017

Contributor

Since Monday, we have this fix live on the app store. Seems to be working great.

Contributor

jonathanpeppers commented Feb 7, 2017

Since Monday, we have this fix live on the app store. Seems to be working great.

StephaneDelcroix added some commits Jan 31, 2017

@StephaneDelcroix StephaneDelcroix merged commit 3241fae into master Feb 10, 2017

2 of 6 checks passed

Android-UITests-C8 Started TeamCity Build Xamarin.Forms :: Debug :: Cycle 8 :: UI Tests :: OSX Test Cloud Package - Run Android 6.0.1
Details
iOS10-UITests-C8 Started TeamCity Build Xamarin.Forms :: Debug :: Cycle 8 :: UI Tests :: OSX Test Cloud Package - Run iOS Unified iOS10
Details
iOS8-UITests-C8 Started TeamCity Build Xamarin.Forms :: Debug :: Cycle 8 :: UI Tests :: OSX Test Cloud Package - Run iOS Unified IOS8
Details
iOS9-UITests-C8 Started TeamCity Build Xamarin.Forms :: Debug :: Cycle 8 :: UI Tests :: OSX Test Cloud Package - Run iOS Unified iOS9
Details
OSX-Debug-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle 8 :: OSX Debug : Running
Details
Windows-Debug-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle 8 :: Windows Debug : Tests passed: 3740, ignored: 10
Details

@StephaneDelcroix StephaneDelcroix deleted the xaml_emptyServiceProvider branch Feb 10, 2017

@samhouts samhouts added D-15.4 and removed cla-not-required labels Oct 10, 2017

@samhouts samhouts added this to the 2.3.5 milestone Jun 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment