Add TV to TargetIdiom #738

Merged
merged 1 commit into from Feb 2, 2017

Conversation

Projects
None yet
7 participants
@rookiejava
Contributor

rookiejava commented Feb 2, 2017

Description of Change

Add TV to TargetIdiom. TargetIdiom.TV indicates that Forms is running on a Tizen app on Tizen TV devices.

Bugs Fixed

  • None

API Changes

Added:

  • TargetIdiom.TV // enum
  • T OnIdiom.TV { get; set; }

Behavioral Changes

  • None

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard
  • Consolidate commits as makes sense
@StephaneDelcroix

This comment has been minimized.

Show comment
Hide comment
@StephaneDelcroix

StephaneDelcroix Feb 2, 2017

Member

@jassmith shouldn't we apply the Platform treatment to Idiom ?

Member

StephaneDelcroix commented Feb 2, 2017

@jassmith shouldn't we apply the Platform treatment to Idiom ?

@StephaneDelcroix StephaneDelcroix requested a review from jassmith Feb 2, 2017

@rmarinho rmarinho merged commit 3c7b291 into xamarin:master Feb 2, 2017

@rookiejava rookiejava deleted the rookiejava:add-tv-to-target-idiom branch Feb 3, 2017

@samhouts samhouts added D-15.4 and removed cla-already-signed labels Oct 10, 2017

@EmilAlipiev

This comment has been minimized.

Show comment
Hide comment
@EmilAlipiev

EmilAlipiev Apr 10, 2018

@StephaneDelcroix I have tested this creating an TV emulator using Android Studio. It doesnt work. It recognizes as Phone. I am using the latest releas 2.5. Should I create a bug for it?

@StephaneDelcroix I have tested this creating an TV emulator using Android Studio. It doesnt work. It recognizes as Phone. I am using the latest releas 2.5. Should I create a bug for it?

@samhouts samhouts added this to the 2.3.5 milestone Jun 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment