[A] Do not throw error for first param in ScrollTo #742

Merged
merged 1 commit into from Feb 17, 2017

Conversation

Projects
None yet
4 participants
@pauldipietro
Member

pauldipietro commented Feb 3, 2017

Description of Change

As it presently exists, using a ListView's ScrollTo while passing in an invalid value (such as listView.ScrollTo("Test", ScrollToPosition.Start, false) will result in the application crashing opposed to silently returning from the method when running on Android. iOS and RT/UWP do not crash, so the inclination is to bring Android's behavior in line with the other platforms and make certain that this is documented. This behavior already existed when IsGroupingEnabled is set to true, and was only applying to situation where it was false.

Bugs Fixed

https://bugzilla.xamarin.com/show_bug.cgi?id=41600

API Changes

None

Behavioral Changes

Aside from a crash not occurring, this behavior should be documented somewhere.

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard
  • Consolidate commits as makes sense

@dnfclas dnfclas added the cla-required label Feb 3, 2017

@pauldipietro pauldipietro requested a review from hartez Feb 3, 2017

@rmarinho rmarinho merged commit 986c46d into master Feb 17, 2017

6 checks passed

Android-UITests-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle 8 :: UI Tests :: OSX Test Cloud Package - Run Android 6.0.1 : Tests passed: 352, i…
Details
OSX-Debug-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle 8 :: OSX Debug : Running
Details
Windows-Debug-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle 8 :: Windows Debug : Tests passed: 3738, ignored: 10
Details
iOS10-UITests-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle 8 :: UI Tests :: OSX Test Cloud Package - Run iOS Unified iOS10 : Tests passed: 34…
Details
iOS8-UITests-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle 8 :: UI Tests :: OSX Test Cloud Package - Run iOS Unified IOS8 : Tests passed: 349…
Details
iOS9-UITests-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle 8 :: UI Tests :: OSX Test Cloud Package - Run iOS Unified iOS9 : Tests passed: 351…
Details

@rmarinho rmarinho deleted the fix-bugzilla41600 branch Jun 22, 2017

@samhouts samhouts added D-15.4 and removed cla-not-required labels Oct 10, 2017

@samhouts samhouts added this to the 2.3.5 milestone Jun 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment