Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement EmptyView on UWP #7438

Merged
merged 1 commit into from Sep 16, 2019
Merged

Implement EmptyView on UWP #7438

merged 1 commit into from Sep 16, 2019

Conversation

hartez
Copy link
Contributor

@hartez hartez commented Sep 8, 2019

Description of Change

Makes the CollectionView EmptyView functionality work on UWP.

Issues Resolved

API Changes

None

Platforms Affected

  • UWP

Behavioral/Visual Changes

None

Before/After Screenshots

Not applicable

Testing Procedure

Control Gallery, navigate to CollectionView Gallery -> EmptyView Galleries and run everything.
Automated tests exist, but this is UWP.

PR Checklist

  • Has automated tests
  • Rebased on top of the target branch at time of PR
  • Changes adhere to coding standard
  • Did you turn off the stove before we left?

Copy link
Member

@jfversluis jfversluis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor nitpicks

@samhouts samhouts moved this from In Review to In Progress in v4.3.0 Sep 10, 2019
v4.3.0 automation moved this from In Progress to In Review Sep 16, 2019
@jfversluis jfversluis merged commit 8b34607 into 4.3.0 Sep 16, 2019
v4.3.0 automation moved this from In Review to Done Sep 16, 2019
CollectionView automation moved this from In Progress to Done Sep 16, 2019
@jfversluis jfversluis deleted the cv-uwp-emptyview branch September 16, 2019 13:03
@samhouts samhouts added this to the 4.3.0 milestone Sep 18, 2019
felipebaltazar pushed a commit to felipebaltazar/Xamarin.Forms that referenced this pull request Oct 16, 2019
felipebaltazar pushed a commit to felipebaltazar/Xamarin.Forms that referenced this pull request Oct 16, 2019
@samhouts samhouts removed this from Done in CollectionView May 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
v4.3.0
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants