New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UWP] Improve toolbar consistency on MasterDetailPage #744

Merged
merged 3 commits into from Mar 6, 2017

Conversation

Projects
None yet
5 participants
@jimmgarrido
Collaborator

jimmgarrido commented Feb 5, 2017

Description of Change

Building off the work done in #638, this fixes some issues introduced with MasterDetailPage:

  • Binding the MasterDetailControlStyle TitleArea visibility to DetailTitleVisibility prevents the Toolbar from being visible when no NavigationPage or Title is present

  • By setting Control.ShouldShowToolbar in its own separate method, it prevents it from being incorrectly overridden which caused the code logic in FormsCommandBar to hide the ToolbarItems on the first Detail page

Bugs Fixed

API Changes

None

Behavioral Changes

None

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard
  • Consolidate commits as makes sense

@samhouts samhouts requested a review from hartez Feb 6, 2017

@hartez

hartez approved these changes Mar 6, 2017

@samhouts samhouts merged commit 65d8480 into xamarin:master Mar 6, 2017

2 checks passed

OSX-Debug-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Stable - Cycle 9 :: OSX Debug : Running
Details
Windows-Debug-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Stable - Cycle 9 :: Windows Debug : Tests passed: 3744, ignored: 10
Details

rmarinho added a commit that referenced this pull request Mar 10, 2017

[UWP] Improve toolbar consistency on MasterDetailPage (#744)
* Improve toolbar consistency on MasterDetailPage

* Properly indent xaml page

@samhouts samhouts added this to the 2.3.4 milestone Jun 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment