New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Entry completed behavior on UWP/WinRT match Android/iOS #747

Merged
merged 4 commits into from Mar 20, 2017

Conversation

Projects
None yet
5 participants
@hartez
Member

hartez commented Feb 6, 2017

Description of Change

Hitting Enter on the soft keyboard on WinRT and UWP now dismisses the soft keyboard (to make the behavior match the Forms Android/iOS behaviors).

Also fixes the internal UnfocusControl method to behave like Android/iOS.

Bugs Fixed

API Changes

  • None

Behavioral Changes

  • None

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard
  • Consolidate commits as makes sense

@dnfclas dnfclas added the cla-required label Feb 6, 2017

@hartez hartez added cla-not-required and removed cla-required labels Feb 6, 2017

@rmarinho rmarinho requested a review from samhouts Feb 9, 2017

@rmarinho rmarinho referenced this pull request Feb 9, 2017

Closed

Unfocus Entry on Enter pressed #755

0 of 4 tasks complete
@JKennedy24

This comment has been minimized.

Show comment
Hide comment
@JKennedy24

JKennedy24 Feb 9, 2017

Looking at this it looks like UWP will TryHide the Keyboard on Enter pressed. Should it not Unfocus the Control?

How do I "Complete" an Entry using the keyboard?

JKennedy24 commented Feb 9, 2017

Looking at this it looks like UWP will TryHide the Keyboard on Enter pressed. Should it not Unfocus the Control?

How do I "Complete" an Entry using the keyboard?

@JKennedy24

This comment has been minimized.

Show comment
Hide comment
@JKennedy24

JKennedy24 Feb 10, 2017

While looking at UWP Entries, does this also fix the issue where the first entry in a ScrollView takes focus when the ScrollView is clicked, explained here: https://bugzilla.xamarin.com/show_bug.cgi?id=52416

JKennedy24 commented Feb 10, 2017

While looking at UWP Entries, does this also fix the issue where the first entry in a ScrollView takes focus when the ScrollView is clicked, explained here: https://bugzilla.xamarin.com/show_bug.cgi?id=52416

@samhouts samhouts self-assigned this Mar 7, 2017

rmarinho and others added some commits Mar 8, 2017

@@ -1,8 +1,10 @@
using System;
using System.ComponentModel;
using System.Diagnostics;

This comment has been minimized.

@samhouts

samhouts Mar 20, 2017

Member

unneccessary

@samhouts

samhouts Mar 20, 2017

Member

unneccessary

@samhouts samhouts removed their assignment Mar 20, 2017

@rmarinho rmarinho merged commit 14a740d into master Mar 20, 2017

2 checks passed

OSX-Debug-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Stable - Cycle 9 :: OSX Debug : Running
Details
Windows-Debug-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Stable - Cycle 9 :: Windows Debug : Tests passed: 3744, ignored: 10
Details

@samhouts samhouts deleted the fix-bugzilla45067-2 branch Mar 21, 2017

@samhouts samhouts added D-15.4 and removed cla-not-required labels Oct 10, 2017

@samhouts samhouts added this to the 2.3.5 milestone Jun 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment