New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WinRT/UWP] Make TextBox better respect background color changes via behaviors #749

Merged
merged 1 commit into from Mar 3, 2017

Conversation

Projects
None yet
4 participants
@pauldipietro
Member

pauldipietro commented Feb 7, 2017

Description of Change

Similar to #618, there's an issue with behaviors and the background color. This is an older fix that was sitting around that was most of the way there for WinRT, but is better than the current situation where the entry background color isn't updating correctly. The only lingering issue is that the border on WinRT (tablet) has a very faint tint to it when the background changes to white (in the repro, it'll be a very light red), but nothing in the template stood out and I wanted to avoid modifying it too much. The phone template is simpler and doesn't seem to have the same problem. If anything stands out on the former, feel free to point it out.

Bugs Fixed

https://bugzilla.xamarin.com/show_bug.cgi?id=44955

API Changes

None

Behavioral Changes

None

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard
  • Consolidate commits as makes sense

@dnfclas dnfclas added the cla-required label Feb 7, 2017

@rmarinho rmarinho merged commit 8871077 into master Mar 3, 2017

6 checks passed

Android-UITests-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle 8 :: UI Tests :: OSX Test Cloud Package - Run Android 6.0.1 : Tests passed: 352, i…
Details
OSX-Debug-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle 8 :: OSX Debug : Running
Details
Windows-Debug-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle 8 :: Windows Debug : Tests passed: 3738, ignored: 10
Details
iOS10-UITests-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle 8 :: UI Tests :: OSX Test Cloud Package - Run iOS Unified iOS10 : Tests passed: 34…
Details
iOS8-UITests-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle 8 :: UI Tests :: OSX Test Cloud Package - Run iOS Unified IOS8 : Tests passed: 349…
Details
iOS9-UITests-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle 8 :: UI Tests :: OSX Test Cloud Package - Run iOS Unified iOS9 : Tests passed: 351…
Details

@pauldipietro pauldipietro referenced this pull request May 19, 2017

Merged

[UWP] Respect TextBox BackgroundFocusBrush Effect #928

3 of 4 tasks complete

@samhouts samhouts deleted the fix-bugzilla44955 branch May 25, 2017

@samhouts samhouts added D-15.4 and removed cla-not-required labels Oct 10, 2017

@samhouts samhouts added this to the 2.3.5 milestone Jun 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment