New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Clean up NavigationBar code in FormsApplicationActivity Platform #753

Merged
merged 1 commit into from Apr 11, 2017

Conversation

Projects
None yet
5 participants
@jimmgarrido
Collaborator

jimmgarrido commented Feb 9, 2017

Description of Change

This gets rid of duplicate calls to some of the methods that update the ActionBar.

It also fixes a bug that affected API 21+ where the background color was reset due to ActionBar.IsShowing not being reliable in the newer versions. I still added a UITest for this even though the issue only affectsFormsApplicationActivity not FormsAppCompat.

Bugs Fixed

API Changes

None

Behavioral Changes

None

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard
  • Consolidate commits as makes sense

@jimmgarrido jimmgarrido changed the title from [Android] Clean up NavigationBar code in FormsApplication Platform to [Android] Clean up NavigationBar code in FormsApplicationActivity Platform Feb 9, 2017

@rmarinho rmarinho requested review from jassmith and hartez Mar 3, 2017

@rmarinho rmarinho merged commit 7458ca3 into xamarin:master Apr 11, 2017

6 checks passed

Android-UITests-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle 8 :: UI Tests :: OSX Test Cloud Package - Run Android 6.0.1 : Tests passed: 353, i…
Details
OSX-Debug-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle 8 :: OSX Debug : Running
Details
Windows-Debug-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle 8 :: Windows Debug : Tests passed: 3738, ignored: 10
Details
iOS10-UITests-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle 8 :: UI Tests :: OSX Test Cloud Package - Run iOS Unified iOS10 : Tests passed: 35…
Details
iOS8-UITests-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle 8 :: UI Tests :: OSX Test Cloud Package - Run iOS Unified IOS8 : Tests passed: 350…
Details
iOS9-UITests-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle 8 :: UI Tests :: OSX Test Cloud Package - Run iOS Unified iOS9 : Tests passed: 352…
Details

@samhouts samhouts added D-15.4 and removed cla-already-signed labels Oct 10, 2017

@samhouts samhouts added this to the 2.5.0 milestone May 5, 2018

@samhouts samhouts modified the milestones: 2.5.0, 2.3.5 Jun 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment