New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Appearing / Disappearing events should not be sent for every page on MDP #754

Merged
merged 3 commits into from Mar 14, 2017

Conversation

Projects
None yet
4 participants
@adrianknight89
Contributor

adrianknight89 commented Feb 9, 2017

Description of Change

Appearing / Disappearing events are being sent for every page on the navigation stack if MainPage is a MasterDetailPage. I added a test project to demonstrate the fix, but it seems the gallery app isn't sending Pause / Resume events. You could add the code to a new XF project to test.

Bugs Fixed

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard
  • Consolidate commits as makes sense

adrianknight89 and others added some commits Feb 9, 2017

Fix MasterDetailPage event cycle
sample code

add tag

change message

changes

changes 2

changes 3

changes 4

@rmarinho rmarinho merged commit 9fb7101 into xamarin:master Mar 14, 2017

@samhouts samhouts added D-15.4 and removed cla-already-signed labels Oct 10, 2017

@samhouts samhouts modified the milestones: 2.3.0, 2.3.5 Jun 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment