New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IEditorController #764

Merged
merged 3 commits into from Feb 21, 2017

Conversation

Projects
None yet
6 participants
@kingces95
Member

kingces95 commented Feb 14, 2017

Description of Change

3ed parties are adding platforms and their renderers need access to internal XF members that are exposed internally via InternalVisibleToAttribute. To expose those internal members we're adding IViewControllers to all renderers; We're making the internal members public but as explicit implementations of an interface to hide them from isense.

API Changes

Added Editor.SendCompleted as explicit implementation of IEditorController.

@jassmith

Docs needs updating

Show outdated Hide outdated Xamarin.Forms.Core/Editor.cs
@@ -68,6 +68,7 @@ public Editor()
return _platformConfigurationRegistry.Value.On<T>();
}
void IEditorController.SendCompleted() => SendCompleted();

This comment has been minimized.

@jassmith

jassmith Feb 14, 2017

Member

Missing new line

@jassmith

jassmith Feb 14, 2017

Member

Missing new line

This comment has been minimized.

@kingces95

kingces95 Feb 14, 2017

Member

Happy to add it. It's just that those two members are so closely related. Would you like me to add a new line for all such members going forward or would you like to reconsider?

@kingces95

kingces95 Feb 14, 2017

Member

Happy to add it. It's just that those two members are so closely related. Would you like me to add a new line for all such members going forward or would you like to reconsider?

This comment has been minimized.

@jassmith

jassmith Feb 14, 2017

Member

Always have the space

@jassmith

jassmith Feb 14, 2017

Member

Always have the space

@kingces95 kingces95 changed the title from IEditorController to IViewController Feb 14, 2017

@kingces95

This comment has been minimized.

Show comment
Hide comment
@kingces95

kingces95 Feb 14, 2017

Member

Any objection to updating docs at the end of the exercise?

Member

kingces95 commented Feb 14, 2017

Any objection to updating docs at the end of the exercise?

@kingces95 kingces95 changed the title from IViewController to IEditorController Feb 14, 2017

kingces95 added some commits Feb 14, 2017

@rmarinho rmarinho merged commit 217a59e into master Feb 21, 2017

6 checks passed

Android-UITests-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle 8 :: UI Tests :: OSX Test Cloud Package - Run Android 6.0.1 : Tests passed: 352, i…
Details
OSX-Debug-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle 8 :: OSX Debug : Running
Details
Windows-Debug-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle 8 :: Windows Debug : Tests passed: 3742, ignored: 10
Details
iOS10-UITests-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle 8 :: UI Tests :: OSX Test Cloud Package - Run iOS Unified iOS10 : Tests passed: 35…
Details
iOS8-UITests-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle 8 :: UI Tests :: OSX Test Cloud Package - Run iOS Unified IOS8 : Tests passed: 350…
Details
iOS9-UITests-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle 8 :: UI Tests :: OSX Test Cloud Package - Run iOS Unified iOS9 : Tests passed: 352…
Details

@rmarinho rmarinho deleted the iviewctl branch Jun 22, 2017

@samhouts samhouts added D-15.4 and removed cla-not-required labels Oct 10, 2017

@samhouts samhouts added this to the 2.3.0 milestone Jun 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment