New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force git to checkout docs using unix line endings #766

Merged
merged 3 commits into from Feb 15, 2017

Conversation

Projects
None yet
5 participants
@kingces95
Member

kingces95 commented Feb 14, 2017

Description of Change

On a clean master branch I expect to be able to run update-docs-windows.bat and have git detect no changes. What actually happens is (1) the line endings are changed from windows to unix by mdoc and (2) non-white spaces changes are made because the build does not always detect that doc changes were made (it checks for "Members Added: 0, Members Deleted: 0" but that is buggy and reports 0 when changes were actually made). To fix (1) we can force all doc files to be checked out by git using unix line endings regardless of dev os by updating .gitattributes. To fix (2), after this change goes through, we can update our build to fail on account of missing docs whenever after running update-docs-windows.bat git detects any changes.

Bugs Fixed

None

API Changes

None

Behavioral Changes

None

PR Checklist

No code changes

This was referenced Feb 15, 2017

@hartez

hartez approved these changes Feb 15, 2017

@StephaneDelcroix StephaneDelcroix merged commit df913c3 into master Feb 15, 2017

6 checks passed

Android-UITests-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle 8 :: UI Tests :: OSX Test Cloud Package - Run Android 6.0.1 : Tests passed: 352, i…
Details
OSX-Debug-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle 8 :: OSX Debug : Running
Details
Windows-Debug-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle 8 :: Windows Debug : Tests passed: 3742, ignored: 10
Details
iOS10-UITests-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle 8 :: UI Tests :: OSX Test Cloud Package - Run iOS Unified iOS10 : Tests passed: 34…
Details
iOS8-UITests-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle 8 :: UI Tests :: OSX Test Cloud Package - Run iOS Unified IOS8 : Tests passed: 349…
Details
iOS9-UITests-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle 8 :: UI Tests :: OSX Test Cloud Package - Run iOS Unified iOS9 : Tests passed: 351…
Details

@StephaneDelcroix StephaneDelcroix deleted the docslf branch Feb 15, 2017

@samhouts samhouts added D-15.4 and removed cla-not-required labels Oct 10, 2017

@samhouts samhouts added this to the 2.3.5 milestone Jun 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment