New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Robust doc change detection #772

merged 3 commits into from Feb 16, 2017


None yet
4 participants

kingces95 commented Feb 15, 2017

Description of Change

I expect that when I run update-docs-windows.bat on a clean master no files change. What actually happens is that sometime doc files change. This happens because the build fails to detect changes to the docs. The build runs update-docs-windows.bat which returns a success exit code if mdoc returns "Members Added: 0, Members Deleted: 0" and a failure exit code otherwise. This doesn't work because mdoc may return that string when docs are non-trivially changed.

To make the change check more robust, I concat all *.xml doc files into a doc.xml before running mdoc and then again into _doc.xml after running mdoc. I fail the build if fc detects those two files are different.

Bugs Fixed


API Changes


Behavioral Changes


PR Checklist


@kingces95 kingces95 changed the title from Doc Regression to Robust doc change detection Feb 16, 2017


hartez approved these changes Feb 16, 2017

@kingces95 kingces95 merged commit 1522c0e into master Feb 16, 2017

1 check passed

Windows-Debug-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle 8 :: Windows Debug : Tests passed: 3742, ignored: 10

@kingces95 kingces95 deleted the docreg branch Feb 16, 2017

rmarinho added a commit that referenced this pull request Mar 3, 2017

[Android] Don't crash if Control is accessed in Effect OnDetached whe…
…n Page is Disposed. (#772)

* Add repro for 51505

* [Android] Don't dispose of EffectControlProvider

* Oops

@samhouts samhouts added D-15.4 and removed cla-not-required labels Oct 10, 2017

@samhouts samhouts modified the milestones: 2.3.0, 2.3.4 Jun 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment