[Android] Don't crash if Control is accessed in Effect OnDetached when Page is Disposed. #773

Merged
merged 4 commits into from Mar 3, 2017

Conversation

Projects
None yet
3 participants
@samhouts
Member

samhouts commented Feb 16, 2017

Description of Change

Revert setting EffectControlProvider to null (added in #360).

Bugs Fixed

API Changes

None

Behavioral Changes

May reintroduce leak in Android. Will need to be reinvestigated.

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard
  • Consolidate commits as makes sense

samhouts added some commits Feb 16, 2017

@samhouts samhouts changed the title from [Android] Don't crash if Control is accessed in Effect OnDetatched when Page is Disposed. to [Android] Don't crash if Control is accessed in Effect OnDetached when Page is Disposed. Feb 16, 2017

@rmarinho

This comment has been minimized.

Show comment
Hide comment
@rmarinho

rmarinho Feb 22, 2017

Member

Failing some tests on iOS @samhouts

Member

rmarinho commented Feb 22, 2017

Failing some tests on iOS @samhouts

@samhouts

This comment has been minimized.

Show comment
Hide comment
@samhouts

samhouts Feb 27, 2017

Member

Fixed!

Member

samhouts commented Feb 27, 2017

Fixed!

@rmarinho rmarinho merged commit bc13d3c into master Mar 3, 2017

6 checks passed

Android-UITests-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Stable - Cycle 9 :: UI Tests :: OSX Test Cloud Package - Run Android 6.0.1 : Tests passe…
Details
OSX-Debug-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Stable - Cycle 9 :: OSX Debug : Running
Details
Windows-Debug-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Stable - Cycle 9 :: Windows Debug : Tests passed: 3743, ignored: 10
Details
iOS10-UITests-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Stable - Cycle 9 :: UI Tests :: OSX Test Cloud Package - Run iOS Unified iOS10 : Running
Details
iOS8-UITests-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Stable - Cycle 9 :: UI Tests :: OSX Test Cloud Package - Run iOS Unified IOS8 : Running
Details
iOS9-UITests-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Stable - Cycle 9 :: UI Tests :: OSX Test Cloud Package - Run iOS Unified iOS9 : Running
Details

@rmarinho rmarinho deleted the fix-bugzilla51505 branch Mar 3, 2017

@samhouts samhouts added this to the 2.3.5 milestone Jun 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment