[UWP] Add width check for Detail on MDP to prevent potential crash #775

Merged
merged 2 commits into from Mar 7, 2017

Conversation

Projects
None yet
4 participants
@pauldipietro
Member

pauldipietro commented Feb 17, 2017

Description of Change

On UWP when a MasterDetailPage is in a TabbedPage, pushing/popping a modal on an active page which isn't the MDP causes a crash; this is due to the Width value being calculated as less than 0 as UpdateBounds is still taking the MDP child page into consideration (for example, when running the reproduction locally, the width value was 320 for the Master pane, causing the Detail width to be -320 and invalid). A simple check to make sure it never goes below 0 prevents this from occurring.

Bugs Fixed

https://bugzilla.xamarin.com/show_bug.cgi?id=43519

API Changes

N/A

Behavioral Changes

Describe any non-bug related behavioral changes that may change how users app behaves when upgrading to this version of the codebase.

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard
  • Consolidate commits as makes sense

@samhouts samhouts merged commit 93fc553 into master Mar 7, 2017

6 checks passed

Android-UITests-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Stable - Cycle 9 :: UI Tests :: OSX Test Cloud Package - Run Android 6.0.1 : Tests passe…
Details
OSX-Debug-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Stable - Cycle 9 :: OSX Debug : Running
Details
Windows-Debug-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Stable - Cycle 9 :: Windows Debug : Tests passed: 3744, ignored: 10
Details
iOS10-UITests-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Stable - Cycle 9 :: UI Tests :: OSX Test Cloud Package - Run iOS Unified iOS10 : Tests p…
Details
iOS8-UITests-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Stable - Cycle 9 :: UI Tests :: OSX Test Cloud Package - Run iOS Unified IOS8 : Tests pa…
Details
iOS9-UITests-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Stable - Cycle 9 :: UI Tests :: OSX Test Cloud Package - Run iOS Unified iOS9 : Tests pa…
Details

@samhouts samhouts deleted the fix-bugzilla43519 branch Mar 7, 2017

@samhouts samhouts added D-15.4 and removed cla-not-required labels Oct 10, 2017

@samhouts samhouts added this to the 2.3.5 milestone Jun 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment