Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Fixed a redundant check that caused a massive slowdown on UWP. #788
Description of Change
Our views on UWP can take anywhere from 30 seconds to 10 minutes to render. This fix takes all those views down to milliseconds. I would rather have just removed all the IsInNativeLayout and also the MaybeInvalidate() function because they seem to not really do anything. InvalidateLayout shouldnt cause a layout cycle unless something else was wrong. So even though we are checking the tree once per control now instead of multiple times, I believe its still too much and shouldnt be needed.
No Tests needed as this is for performance only. I did see some performance functions in the master code if that is something that can be used on UWP then it would be interesting to see the differences on complex trees.
UWP views should load extremely fast now, especially in release.
The issue is it will end up doing the same thing as I am not sure why it's happening because on my side it looks correct and I even counted them. Did the web edits fix it?
Anyway I would love to figure it out so I can fix some other stuff when I have time.
@rmarinho YUP!! That was it, something switched me over to Insert Spaces. UGHH!!! What is weird is I am hitting tab but that setting must switch them out automatically on the file. So even though locally I see tabs, locally I am hitting tab, the file has spaces? What a cluster man. Thanks for the help on that. So are we good with the web edits or should I just create new PRs for my fixes?