[Android] Small performance fixes to ListViewRenderer, PlatformSpecific IsFastScrollEnabled #797

Merged
merged 8 commits into from Mar 8, 2017

Conversation

Projects
None yet
4 participants
@rmarinho
Member

rmarinho commented Mar 2, 2017

Description of Change

Work on some feedback from @Clancey for ListViewRenderer ,

  • Add Platform specific for IsFastScrollEnabled
  • Cache count

API Changes

Added:

  • Platform specific IsFastScrollEnabled

Usage:

  • listView.On<Android>().SetIsFastScrollEnabled(true);

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard
  • Consolidate commits as makes sense

@rmarinho rmarinho changed the title from [Android] Small performance fixes to ListViewRenderer to [Android] Small performance fixes to ListViewRenderer, PlatformSpecific IsFastScrollEnabled Mar 3, 2017

+ {
+ public static readonly BindableProperty IsFastScrollEnabledProperty =
+ BindableProperty.Create("IsFastScrollEnabled", typeof(bool),
+ typeof(ListView), true);

This comment has been minimized.

@StephaneDelcroix

StephaneDelcroix Mar 3, 2017

Member

are we sure about true as default value ?

@StephaneDelcroix

StephaneDelcroix Mar 3, 2017

Member

are we sure about true as default value ?

This comment has been minimized.

@rmarinho

rmarinho Mar 3, 2017

Member

thanks, fixed!

@rmarinho

rmarinho Mar 3, 2017

Member

thanks, fixed!

rmarinho added some commits Mar 2, 2017

@samhouts

This comment has been minimized.

Show comment
Hide comment
@samhouts

samhouts Mar 7, 2017

Member

Some tests failing, @rmarinho.

Member

samhouts commented Mar 7, 2017

Some tests failing, @rmarinho.

rmarinho added some commits Mar 7, 2017

@rmarinho rmarinho requested a review from samhouts Mar 7, 2017

@rmarinho

This comment has been minimized.

Show comment
Hide comment
@rmarinho

rmarinho Mar 7, 2017

Member

@samhouts , @StephaneDelcroix ready for another review.

Member

rmarinho commented Mar 7, 2017

@samhouts , @StephaneDelcroix ready for another review.

@rmarinho rmarinho merged commit 1ad18e3 into master Mar 8, 2017

6 checks passed

Android-UITests-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Stable - Cycle 9 :: UI Tests :: OSX Test Cloud Package - Run Android 6.0.1 : Tests passe…
Details
OSX-Debug-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Stable - Cycle 9 :: OSX Debug : Running
Details
Windows-Debug-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Stable - Cycle 9 :: Windows Debug : Tests passed: 3744, ignored: 10
Details
iOS10-UITests-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Stable - Cycle 9 :: UI Tests :: OSX Test Cloud Package - Run iOS Unified iOS10 : Tests p…
Details
iOS8-UITests-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Stable - Cycle 9 :: UI Tests :: OSX Test Cloud Package - Run iOS Unified IOS8 : Tests pa…
Details
iOS9-UITests-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Stable - Cycle 9 :: UI Tests :: OSX Test Cloud Package - Run iOS Unified iOS9 : Tests pa…
Details

@rmarinho rmarinho deleted the fix-android-count branch Mar 8, 2017

@samhouts samhouts added D-15.4 and removed cla-already-signed labels Oct 10, 2017

@samhouts samhouts added this to the 2.3.5 milestone Jun 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment