New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C] move the Font proxying into FontElement #799

Merged
merged 2 commits into from Mar 9, 2017

Conversation

Projects
None yet
5 participants
@StephaneDelcroix
Member

StephaneDelcroix commented Mar 3, 2017

Description of Change

As Font can be used as a proxy for family, size and attributes, and the synchronization has to happen both ways, we had some sync code repeated in multiple places.

Move all that sync code into FontElement.

This also allow setting the Font property via a stylesheet to controls like Entry who doesn't have a Font property at all.

Bugs Fixed

/

API Changes

/

Behavioral Changes

/

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard
  • Consolidate commits as makes sense

@rmarinho rmarinho merged commit 025d961 into master Mar 9, 2017

@StephaneDelcroix StephaneDelcroix deleted the unify_font_handling branch Mar 10, 2017

@samhouts samhouts added D-15.4 and removed cla-not-required labels Oct 10, 2017

@samhouts samhouts added this to the 2.3.5 milestone Jun 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment