New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue where errant "." were appearing on droid controls due to … #801

Merged
merged 1 commit into from Mar 7, 2017

Conversation

Projects
None yet
4 participants
@BradChase2011
Contributor

BradChase2011 commented Mar 4, 2017

…hints.

Description of Change

Fixed issue where Android Hints were causing a "." to be placed on all entry controls.

Bugs Fixed

Accessibility support on Android caused a ". " to be place on every control.

No tests believe to be needed. If there is another issue where certain hints are not being defaulted on certain setups then tests will probably be needed.

API Changes

None

Behavioral Changes

Android will now have errant ". " replaced with "" in the UI where Hint and Name are non existent.

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard
  • Consolidate commits as makes sense
@dnfclas

This comment has been minimized.

Show comment
Hide comment
@dnfclas

dnfclas Mar 4, 2017

@BradChase2011,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by .NET Foundation. We will now review your pull request.
Thanks,
.NET Foundation Pull Request Bot

dnfclas commented Mar 4, 2017

@BradChase2011,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by .NET Foundation. We will now review your pull request.
Thanks,
.NET Foundation Pull Request Bot

@BradChase2011

This comment has been minimized.

Show comment
Hide comment
@BradChase2011

BradChase2011 Mar 4, 2017

Contributor

closed out PR: #786

Contributor

BradChase2011 commented Mar 4, 2017

closed out PR: #786

@rmarinho rmarinho merged commit 2b92142 into xamarin:master Mar 7, 2017

2 checks passed

OSX-Debug-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Stable - Cycle 9 :: OSX Debug : Running
Details
Windows-Debug-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Stable - Cycle 9 :: Windows Debug : Tests passed: 3744, ignored: 10
Details

@samhouts samhouts added D-15.4 and removed cla-already-signed labels Oct 10, 2017

@samhouts samhouts modified the milestones: 2.3.0, 2.3.5 Jun 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment