[Android] Add null checks to ActivityIndicator #804

Merged
merged 1 commit into from Mar 8, 2017

Conversation

Projects
None yet
5 participants
@samhouts
Member

samhouts commented Mar 8, 2017

Description of Change

Null check all the things to prevent the XF Previewer from crashing. No tests added, but did verify that this stops the crash in https://github.com/xamarin/app-crm on SplashPage.xaml.

Bugs Fixed

API Changes

None

Behavioral Changes

None

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard
  • Consolidate commits as makes sense
@alanmcgovern

If we can get it into 2.3.4 too that'd be 👍

@rmarinho rmarinho merged commit 1b39d02 into master Mar 8, 2017

3 checks passed

Android-UITests-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Stable - Cycle 9 :: UI Tests :: OSX Test Cloud Package - Run Android 6.0.1 : Tests passe…
Details
OSX-Debug-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Stable - Cycle 9 :: OSX Debug : Running
Details
Windows-Debug-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Stable - Cycle 9 :: Windows Debug : Tests passed: 3744, ignored: 10
Details

@samhouts samhouts deleted the fix-bugzilla52885 branch Mar 8, 2017

@samhouts samhouts added this to the 2.3.4 milestone Jun 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment