New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EditorBrowsableAttribute to public classes/interfaces in XF.Internals #806

Merged
merged 1 commit into from Mar 9, 2017

Conversation

Projects
None yet
6 participants
@kingces95
Member

kingces95 commented Mar 9, 2017

Description of Change

Add [EditorBrowsable(EditorBrowsableState.Never)] to classes and interfaces in XF.Internals hides these classes and all their members from isense when XF.Core is referenced as an assembly. Our policy is that customers should not bind to these members. Hiding them in this fashion makes it more difficult for them to bind to them by mistake.

When referenced as a csproj the members will still appear in isense.

Bugs Fixed

None

API Changes

None

Behavioral Changes

None

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard
  • Consolidate commits as makes sense

@dnfclas dnfclas added the cla-required label Mar 9, 2017

@@ -10,9 +10,9 @@
namespace Xamarin.Forms.Internals
{
[EditorBrowsable(EditorBrowsableState.Never)]
public static class NativeBindingHelpers

This comment has been minimized.

@StephaneDelcroix

StephaneDelcroix Mar 9, 2017

Member

why is this public again ?

@StephaneDelcroix

StephaneDelcroix Mar 9, 2017

Member

why is this public again ?

@jassmith jassmith merged commit b9b9d25 into master Mar 9, 2017

6 checks passed

Android-UITests-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Stable - Cycle 9 :: UI Tests :: OSX Test Cloud Package - Run Android 6.0.1 : Tests passe…
Details
OSX-Debug-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Stable - Cycle 9 :: OSX Debug : Running
Details
Windows-Debug-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Stable - Cycle 9 :: Windows Debug : Tests passed: 3744, ignored: 10
Details
iOS10-UITests-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Stable - Cycle 9 :: UI Tests :: OSX Test Cloud Package - Run iOS Unified iOS10 : Tests p…
Details
iOS8-UITests-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Stable - Cycle 9 :: UI Tests :: OSX Test Cloud Package - Run iOS Unified IOS8 : Tests pa…
Details
iOS9-UITests-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Stable - Cycle 9 :: UI Tests :: OSX Test Cloud Package - Run iOS Unified iOS9 : Tests pa…
Details

@rmarinho rmarinho deleted the hideinternals branch Jun 22, 2017

@samhouts samhouts added D-15.4 and removed cla-not-required labels Oct 10, 2017

@samhouts samhouts added this to the 2.3.5 milestone Jun 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment