Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Implicit impl of controller ifaces #807
Description of Change
Convert from explicit to implicit implementation +
I'd argue that we still consume the same the API as our customers. The difference is in how the API is consumed. We consume the core API directly (which, IMHO, results in more readable code) while our customers consume the API through an interface -- but in either case we're consuming the same API.
On the other hand, your point is well taken that the implementation of the renderer and custom renderer do not look the same even if they are consuming the same API. It just that IMHO the benefit of allowing customers to copy/paste from our renderers doesn't outweigh the cost of the less readable callsites.
@jassmith, it's your show, let me know if you'd like me to proceed simplifying the callsites or to hold off.