New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 52962; Cont refresh even when pullToRefresh is disabled #810

Merged
merged 1 commit into from Apr 6, 2017

Conversation

Projects
None yet
4 participants
@kingces95
Member

kingces95 commented Mar 10, 2017

Description of Change

Expected that disabling pullToRefresh does not kill an in progress refresh. Actually observed disabling pullToRefresh killed in progress refresh. Consider the case of bug 52962:

  1. User pulls to refresh
  2. App RefreshCommand fires (at this point _refresh.Refreshing is true)
  3. RefreshCommand disables itself via a call to ChangeCanExecute which returns false
    maybe the command it's attached to a button the app wants disabled)
  4. OnCommandCanExecuteChanged handler sets RefreshAllowed to false because the RefreshCommand is disabled
  5. We end up here; A refresh is in progress while being asked to disable pullToRefresh

Bugs Fixed

https://bugzilla.xamarin.com/show_bug.cgi?id=52962

API Changes

None

Behavioral Changes

As described.

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard
  • Consolidate commits as makes sense

@kingces95 kingces95 requested review from rmarinho and samhouts Apr 3, 2017

@rmarinho rmarinho merged commit 45a6a80 into master Apr 6, 2017

5 checks passed

OSX-Debug-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Stable - Cycle 9 :: OSX Debug : Running
Details
Windows-Debug-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Stable - Cycle 9 :: Windows Debug : Tests passed: 3744, ignored: 10
Details
iOS10-UITests-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Stable - Cycle 9 :: UI Tests :: OSX Test Cloud Package - Run iOS Unified iOS10 : Tests p…
Details
iOS8-UITests-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Stable - Cycle 9 :: UI Tests :: OSX Test Cloud Package - Run iOS Unified IOS8 : Tests pa…
Details
iOS9-UITests-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Stable - Cycle 9 :: UI Tests :: OSX Test Cloud Package - Run iOS Unified iOS9 : Tests pa…
Details

@rmarinho rmarinho deleted the bz52962 branch Jun 22, 2017

@samhouts samhouts added D-15.4 and removed cla-not-required labels Oct 10, 2017

@samhouts samhouts modified the milestones: 2.3.0, 2.3.5 Jun 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment