Bug 53224; Disable Cell if Command IsEnabled false #812

Merged
merged 1 commit into from Mar 15, 2017

Conversation

Projects
None yet
4 participants
@kingces95
Member

kingces95 commented Mar 13, 2017

TextCell expected to be disabled if Command.IsEnabled is false. Actually, on UAP, TextCell remained enabled. Fixed by checking if Cell.IsEnabled before dispatching command.

Bugs Fixed

https://bugzilla.xamarin.com/show_bug.cgi?id=53224

API Changes

None

Behavioral Changes

UAP TextCell no longer dispatches Command if the Command is disabled.

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard
  • Consolidate commits as makes sense

@rmarinho rmarinho merged commit 295cba6 into master Mar 15, 2017

2 checks passed

OSX-Debug-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Stable - Cycle 9 :: OSX Debug : Running
Details
Windows-Debug-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Stable - Cycle 9 :: Windows Debug : Tests passed: 3744, ignored: 10
Details

@rmarinho rmarinho deleted the bz53224 branch Jun 22, 2017

@samhouts samhouts added D-15.4 and removed cla-not-required labels Oct 10, 2017

@samhouts samhouts modified the milestone: 3.1.0 Jun 1, 2018

@samhouts samhouts added this to Done in vNext+1 (master) Jun 26, 2018

@samhouts samhouts removed this from Done in vNext+1 (master) Jun 26, 2018

@samhouts samhouts modified the milestones: 2.3.0, 2.3.5 Jun 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment