Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
[Core] Fix internal children clear logic #820
Description of Change
I think the code before the change was intended to remove all the items in the InternalChildren. However, the code is removing only the odd-numbered items from InternalChildren. This PR modifies the code to fit the original intent.
This PR modifies the code to fit the original intent.
Mar 20, 2017
7 checks passed
Just a small remark. Speeding up this loop would benefit from a for loop as the original code did but with i set to Count and decreasing to zero, also adding count to a local var for the loop check and finally calling RemoveAt(i). This would effectively do the same while removing the 2x Count property access on every iteration.