New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C] fix NIE in Span #828

Merged
merged 1 commit into from Mar 21, 2017

Conversation

Projects
None yet
4 participants
@StephaneDelcroix
Member

StephaneDelcroix commented Mar 21, 2017

Description of Change

Use a fake BO in Span to benefit from FontElement logic sharing

Bugs Fixed

  • the one @samhouts whispered in my ear during my sleep

API Changes

/

Behavioral Changes

/

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard
  • Consolidate commits as makes sense
@@ -196,6 +192,10 @@
<Name>Xamarin.Forms.Platform.iOS</Name>
<IsAppExtension>false</IsAppExtension>
</ProjectReference>
<ProjectReference Include="..\Stubs\Xamarin.Forms.Platform.iOS\Xamarin.Forms.Platform.iOS %28Forwarders%29.csproj">
<Project>{39B3457F-01D8-43D0-8E84-D8C4F73CF48D}</Project>
<Name>Xamarin.Forms.Platform.iOS (Forwarders)</Name>

This comment has been minimized.

@StephaneDelcroix

StephaneDelcroix Mar 21, 2017

Member

this is somehow required to build on latest vs4mac

@StephaneDelcroix

StephaneDelcroix Mar 21, 2017

Member

this is somehow required to build on latest vs4mac

@rmarinho

This comment has been minimized.

Show comment
Hide comment
@rmarinho

rmarinho Mar 21, 2017

Member

Can we add some tests ?

Member

rmarinho commented Mar 21, 2017

Can we add some tests ?

@StephaneDelcroix

This comment has been minimized.

Show comment
Hide comment
@StephaneDelcroix

StephaneDelcroix Mar 21, 2017

Member

no. all of this is already tested

Member

StephaneDelcroix commented Mar 21, 2017

no. all of this is already tested

@samhouts samhouts merged commit ada46c3 into master Mar 21, 2017

6 checks passed

Android-UITests-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Stable - Cycle 9 :: UI Tests :: OSX Test Cloud Package - Run Android 6.0.1 : Tests passe…
Details
OSX-Debug-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Stable - Cycle 9 :: OSX Debug : Running
Details
Windows-Debug-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Stable - Cycle 9 :: Windows Debug : Tests passed: 3749, ignored: 10
Details
iOS10-UITests-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Stable - Cycle 9 :: UI Tests :: OSX Test Cloud Package - Run iOS Unified iOS10 : Tests p…
Details
iOS8-UITests-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Stable - Cycle 9 :: UI Tests :: OSX Test Cloud Package - Run iOS Unified IOS8 : Tests pa…
Details
iOS9-UITests-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Stable - Cycle 9 :: UI Tests :: OSX Test Cloud Package - Run iOS Unified iOS9 : Tests pa…
Details

@samhouts samhouts deleted the fix-spans branch Mar 21, 2017

@samhouts samhouts added D-15.4 and removed cla-not-required labels Oct 10, 2017

@samhouts samhouts added this to the 2.3.5 milestone Jun 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment